From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: [PATCH bpf v2] xdp: Fix handling of devmap in generic XDP Date: Sat, 16 Jun 2018 00:27:58 +0200 Message-ID: <030a8764-e7c5-2a7a-fab9-cee8a3839679@iogearbox.net> References: <1528942062-2353-1-git-send-email-makita.toshiaki@lab.ntt.co.jp> <20180614104959.4e4e57b8@redhat.com> <23f82d78-88dd-a5e5-ecb1-718fcf5c4a1e@lab.ntt.co.jp> <20180614113302.30472d4e@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Alexei Starovoitov , netdev@vger.kernel.org To: Jesper Dangaard Brouer , Toshiaki Makita Return-path: Received: from www62.your-server.de ([213.133.104.62]:40634 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756429AbeFOW2F (ORCPT ); Fri, 15 Jun 2018 18:28:05 -0400 In-Reply-To: <20180614113302.30472d4e@redhat.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 06/14/2018 11:33 AM, Jesper Dangaard Brouer wrote: > On Thu, 14 Jun 2018 18:00:22 +0900 > Toshiaki Makita wrote: >> On 2018/06/14 17:49, Jesper Dangaard Brouer wrote: >>> On Thu, 14 Jun 2018 11:07:42 +0900 >>> Toshiaki Makita wrote: >>> >>>> Commit 67f29e07e131 ("bpf: devmap introduce dev_map_enqueue") changed >>>> the return value type of __devmap_lookup_elem() from struct net_device * >>>> to struct bpf_dtab_netdev * but forgot to modify generic XDP code >>>> accordingly. >>>> Thus generic XDP incorrectly used struct bpf_dtab_netdev where struct >>>> net_device is expected, then skb->dev was set to invalid value. >>>> >>>> v2: >>>> - Fix compiler warning without CONFIG_BPF_SYSCALL. >>>> >>>> Fixes: 67f29e07e131 ("bpf: devmap introduce dev_map_enqueue") >>>> Signed-off-by: Toshiaki Makita >>> >>> Thanks for catching this! >>> >>> Acked-by: Jesper Dangaard Brouer Applied to bpf, thanks Toshiaki!