RE: [PATCH net-next 2/4] net: wangxun: Implement get_ts_info

["Jiawen Wu" <jiawenwu@trustnetic.com>]

> > +int wx_get_ts_info(struct net_device *dev,
> > +		   struct kernel_ethtool_ts_info *info)
> > +{
> > +	struct wx *wx = netdev_priv(dev);
> > +
> > +	info->rx_filters = BIT(HWTSTAMP_FILTER_NONE) |
> > +			   BIT(HWTSTAMP_FILTER_PTP_V1_L4_SYNC) |
> > +			   BIT(HWTSTAMP_FILTER_PTP_V1_L4_DELAY_REQ) |
> > +			   BIT(HWTSTAMP_FILTER_PTP_V2_L2_EVENT) |
> > +			   BIT(HWTSTAMP_FILTER_PTP_V2_L4_EVENT) |
> > +			   BIT(HWTSTAMP_FILTER_PTP_V2_SYNC) |
> > +			   BIT(HWTSTAMP_FILTER_PTP_V2_L2_SYNC) |
> > +			   BIT(HWTSTAMP_FILTER_PTP_V2_L4_SYNC) |
> > +			   BIT(HWTSTAMP_FILTER_PTP_V2_DELAY_REQ) |
> > +			   BIT(HWTSTAMP_FILTER_PTP_V2_L2_DELAY_REQ) |
> > +			   BIT(HWTSTAMP_FILTER_PTP_V2_L4_DELAY_REQ) |
> > +			   BIT(HWTSTAMP_FILTER_PTP_V2_EVENT);
> > +
> > +	info->so_timestamping = SOF_TIMESTAMPING_TX_SOFTWARE |
> > +				SOF_TIMESTAMPING_RX_SOFTWARE |
> 
> SOF_TIMESTAMPING_RX_SOFTWARE is now moved to core networking and there
> is no need to report it from driver
> 
> > +				SOF_TIMESTAMPING_SOFTWARE |
> 
> SOF_TIMESTAMPING_SOFTWARE means "software-system-clock". What kind of
> software clock is provided by the driver?

I think I should remove it.