From: David Ahern <dsahern@kernel.org>
To: Breno Leitao <leitao@debian.org>,
kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com,
edumazet@google.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, horms@kernel.org
Subject: Re: [PATCH net-next] ipv6/sit: Do not allocate stats in the driver
Date: Thu, 22 Feb 2024 10:32:22 -0700 [thread overview]
Message-ID: <032f132f-274d-4a23-82b8-fcc4393f7954@kernel.org> (raw)
In-Reply-To: <20240221161732.3026127-1-leitao@debian.org>
On 2/21/24 9:17 AM, Breno Leitao wrote:
> With commit 34d21de99cea9 ("net: Move {l,t,d}stats allocation to core and
> convert veth & vrf"), stats allocation could be done on net core
> instead of this driver.
>
> With this new approach, the driver doesn't have to bother with error
> handling (allocation failure checking, making sure free happens in the
> right spot, etc). This is core responsibility now.
>
> Remove the allocation in the ipv6/sit driver and leverage the network
> core allocation.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---
> net/ipv6/sit.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2024-02-22 17:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 16:17 [PATCH net-next] ipv6/sit: Do not allocate stats in the driver Breno Leitao
2024-02-22 13:36 ` Simon Horman
2024-02-22 17:32 ` David Ahern [this message]
2024-02-23 3:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=032f132f-274d-4a23-82b8-fcc4393f7954@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).