From: Roger Quadros <rogerq@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, maciej.fijalkowski@intel.com,
andrew@lunn.ch, edumazet@google.com, pabeni@redhat.com,
vigneshr@ti.com, linux-omap@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 net-next 4/6] net: ethernet: ti: am65-cpsw: Add suspend/resume support
Date: Thu, 8 Dec 2022 11:49:48 +0200 [thread overview]
Message-ID: <034523fc-5ecd-87ea-c0b4-8c21705cc50d@kernel.org> (raw)
In-Reply-To: <20221207202120.12bc7c33@kernel.org>
On 08/12/2022 06:21, Jakub Kicinski wrote:
> On Tue, 6 Dec 2022 11:44:17 +0200 Roger Quadros wrote:
>> ret = pm_runtime_resume_and_get(common->dev);
>> if (ret < 0)
>> return ret;
>>
>> + /* Idle MAC port */
>> + cpsw_sl_ctl_set(port->slave.mac_sl, CPSW_SL_CTL_CMD_IDLE);
>> + cpsw_sl_wait_for_idle(port->slave.mac_sl, 100);
>> + cpsw_sl_ctl_reset(port->slave.mac_sl);
>> +
>> + /* soft reset MAC */
>> + cpsw_sl_reg_write(port->slave.mac_sl, CPSW_SL_SOFT_RESET, 1);
>> + mdelay(1);
>> + reg = cpsw_sl_reg_read(port->slave.mac_sl, CPSW_SL_SOFT_RESET);
>> + if (reg) {
>> + dev_err(common->dev, "soft RESET didn't complete\n");
>> + return -ETIMEDOUT;
>
> Doesn't this function leak power management references on almost all
> error paths? Not really related to this set, tho.
Oh yes it does. I'll send a separate fix.
cheers,
-roger
next prev parent reply other threads:[~2022-12-08 9:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 9:44 [PATCH v5 net-next 0/6] net: ethernet: ti: am65-cpsw: Fix set channel operation Roger Quadros
2022-12-06 9:44 ` [PATCH v5 net-next 1/6] Revert "net: ethernet: ti: am65-cpsw: Fix hardware switch mode on suspend/resume" Roger Quadros
2022-12-06 9:44 ` [PATCH v5 net-next 2/6] Revert "net: ethernet: ti: am65-cpsw: retain PORT_VLAN_REG after suspend/resume" Roger Quadros
2022-12-06 9:44 ` [PATCH v5 net-next 3/6] Revert "net: ethernet: ti: am65-cpsw: Add suspend/resume support" Roger Quadros
2022-12-06 9:44 ` [PATCH v5 net-next 4/6] net: ethernet: ti: am65-cpsw: Add suspend/resume support Roger Quadros
2022-12-08 4:21 ` Jakub Kicinski
2022-12-08 9:49 ` Roger Quadros [this message]
2022-12-06 9:44 ` [PATCH v5 net-next 5/6] net: ethernet: ti: am65-cpsw: retain PORT_VLAN_REG after suspend/resume Roger Quadros
2022-12-06 9:44 ` [PATCH v5 net-next 6/6] net: ethernet: ti: am65-cpsw: Fix hardware switch mode on suspend/resume Roger Quadros
2022-12-06 10:05 ` [PATCH v5 net-next 0/6] net: ethernet: ti: am65-cpsw: Fix set channel operation Leon Romanovsky
2022-12-06 10:15 ` Roger Quadros
2022-12-06 11:49 ` Leon Romanovsky
2022-12-08 4:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=034523fc-5ecd-87ea-c0b4-8c21705cc50d@kernel.org \
--to=rogerq@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).