From: Eric Dumazet <eric.dumazet@gmail.com>
To: Mat Martineau <mathew.j.martineau@linux.intel.com>,
netdev@vger.kernel.org, mptcp@lists.01.org
Cc: Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next v5 09/11] tcp: Check for filled TCP option space before SACK
Date: Fri, 20 Dec 2019 07:27:54 -0800 [thread overview]
Message-ID: <034d02ef-e760-3cfa-a6a4-4a1943e73783@gmail.com> (raw)
In-Reply-To: <20191219223434.19722-10-mathew.j.martineau@linux.intel.com>
On 12/19/19 2:34 PM, Mat Martineau wrote:
> Update the SACK check to work with zero option space available, a case
> that's possible with MPTCP but not MD5+TS. Maintained only one
> conditional branch for insufficient SACK space.
>
> v1 -> v2:
> - Moves the check inside the SACK branch by taking recent SACK fix:
>
> 9424e2e7ad93 (tcp: md5: fix potential overestimation of TCP option space)
>
> in to account, but modifies it to work in MPTCP scenarios beyond the
> MD5+TS corner case.
>
> Co-developed-by: Paolo Abeni <pabeni@redhat.com>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
> ---
Reviewed-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2019-12-20 15:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 22:34 [PATCH net-next v5 00/11] Multipath TCP: Prerequisites Mat Martineau
2019-12-19 22:34 ` [PATCH net-next v5 01/11] net: Make sock protocol value checks more specific Mat Martineau
2019-12-20 15:35 ` Eric Dumazet
2019-12-19 22:34 ` [PATCH net-next v5 02/11] sock: Make sk_protocol a 16-bit value Mat Martineau
2019-12-20 15:37 ` Eric Dumazet
2019-12-19 22:34 ` [PATCH net-next v5 03/11] tcp: Define IPPROTO_MPTCP Mat Martineau
2019-12-20 15:39 ` Eric Dumazet
2019-12-19 22:34 ` [PATCH net-next v5 04/11] tcp: Add MPTCP option number Mat Martineau
2019-12-20 15:39 ` Eric Dumazet
2019-12-19 22:34 ` [PATCH net-next v5 05/11] tcp, ulp: Add clone operation to tcp_ulp_ops Mat Martineau
2019-12-20 15:26 ` Eric Dumazet
2019-12-20 16:21 ` Paolo Abeni
2019-12-20 16:26 ` Eric Dumazet
2019-12-19 22:34 ` [PATCH net-next v5 06/11] mptcp: Add MPTCP to skb extensions Mat Martineau
2019-12-20 15:33 ` Eric Dumazet
2019-12-19 22:34 ` [PATCH net-next v5 07/11] tcp: coalesce/collapse must respect MPTCP extensions Mat Martineau
2019-12-20 15:25 ` Eric Dumazet
2019-12-20 16:17 ` Mat Martineau
2019-12-19 22:34 ` [PATCH net-next v5 08/11] tcp: Export TCP functions and ops struct Mat Martineau
2019-12-20 15:31 ` Eric Dumazet
2019-12-19 22:34 ` [PATCH net-next v5 09/11] tcp: Check for filled TCP option space before SACK Mat Martineau
2019-12-20 15:27 ` Eric Dumazet [this message]
2019-12-19 22:34 ` [PATCH net-next v5 10/11] tcp: clean ext on tx recycle Mat Martineau
2019-12-20 15:29 ` Eric Dumazet
2019-12-19 22:34 ` [PATCH net-next v5 11/11] skb: add helpers to allocate ext independently from sk_buff Mat Martineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=034d02ef-e760-3cfa-a6a4-4a1943e73783@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=mathew.j.martineau@linux.intel.com \
--cc=mptcp@lists.01.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).