From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E7B9C43603 for ; Fri, 20 Dec 2019 15:28:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D895121D7E for ; Fri, 20 Dec 2019 15:28:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kQ6Lv3Xk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727407AbfLTP17 (ORCPT ); Fri, 20 Dec 2019 10:27:59 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:42841 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727395AbfLTP15 (ORCPT ); Fri, 20 Dec 2019 10:27:57 -0500 Received: by mail-wr1-f65.google.com with SMTP id q6so9770246wro.9 for ; Fri, 20 Dec 2019 07:27:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=QgvFx5YHtxnECnkDBTqxzi0EKbhnWjIBCvLL8T47+vI=; b=kQ6Lv3XkbX3KIEyHrz312HKNFMhGmuM0GPmyZ85L4Qb1qsZ3vS48omlzbhvg1m7rv0 ZMsas043coV+I5M8/bN2SpnBSnf30zYcnCF98ZN9/Phu3ani77nk1wb+rHOjjBmL16s4 JWSBAYbAROCTKypMACXva0kCw1qRgndS6AhPFuz8/YlByLO6XsnqUzuG2UqIhcamrR+/ rgg6MoADwoO3fV6l6mMNDQr42wTExhgEW/zxjgs+FRvuMxcpM7A31snj5+JAHhXVdM7v gHhHNyUWNCfKWRoNxIXpLoPXBona/UgOQCrzZUdWq2FGnf9DzEyV7JOWg1BGmlpVubyU fxRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QgvFx5YHtxnECnkDBTqxzi0EKbhnWjIBCvLL8T47+vI=; b=ZLSV6SZ3Ykds9FbiZqeh8gaMBrxDvAPvwhcPeZww3ZxmKib5qZuSMxAAyN/3QUAI/O 3jYAq59OwUnHvnZygCBDkPJNeyFMM1HiDVlHe0Y1tHUMo3Xyj5+DQOjBoF/lcb3AQja0 CkLtjegQf9weAKPhw89mfT6S11Up8A4o2GS7hlM89hRh7drRybXUf8qy+5YWwlCAMgyx 0rIA0BO17beMYxIkwkp4VxAeFjKclanVYh6Hyu0VmXIr9KcjN8qkBJmw3k7Xb5+lHb9/ x7C5XtC8/pb3ibdKT070RysO4xwSB+P+VbmZz2PrpyX9fAfP7GQDtdr3ldDPPKpRLMVw VDhQ== X-Gm-Message-State: APjAAAXJUzeAMjLlpQUDv0sJqNh/3ZobV+EGzIoLBHVnYkiG9DUNR+WP t8FZ7WwzHiTxizWi4jVZrEE= X-Google-Smtp-Source: APXvYqz+q+5o566ccpNL+Wp1HQq1d6uok6rYp8sP0AyGG6XqKSm98H8uQZZg8XrNikrtj9HuCFMz9w== X-Received: by 2002:a5d:4602:: with SMTP id t2mr15593815wrq.37.1576855676229; Fri, 20 Dec 2019 07:27:56 -0800 (PST) Received: from [192.168.8.147] (72.173.185.81.rev.sfr.net. [81.185.173.72]) by smtp.gmail.com with ESMTPSA id q3sm9735355wmj.38.2019.12.20.07.27.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2019 07:27:55 -0800 (PST) Subject: Re: [PATCH net-next v5 09/11] tcp: Check for filled TCP option space before SACK To: Mat Martineau , netdev@vger.kernel.org, mptcp@lists.01.org Cc: Paolo Abeni References: <20191219223434.19722-1-mathew.j.martineau@linux.intel.com> <20191219223434.19722-10-mathew.j.martineau@linux.intel.com> From: Eric Dumazet Message-ID: <034d02ef-e760-3cfa-a6a4-4a1943e73783@gmail.com> Date: Fri, 20 Dec 2019 07:27:54 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191219223434.19722-10-mathew.j.martineau@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 12/19/19 2:34 PM, Mat Martineau wrote: > Update the SACK check to work with zero option space available, a case > that's possible with MPTCP but not MD5+TS. Maintained only one > conditional branch for insufficient SACK space. > > v1 -> v2: > - Moves the check inside the SACK branch by taking recent SACK fix: > > 9424e2e7ad93 (tcp: md5: fix potential overestimation of TCP option space) > > in to account, but modifies it to work in MPTCP scenarios beyond the > MD5+TS corner case. > > Co-developed-by: Paolo Abeni > Signed-off-by: Paolo Abeni > Signed-off-by: Mat Martineau > --- Reviewed-by: Eric Dumazet