Re: [PATCH iwl-net v3] i40e: fix hot issue NVM content is corrupted after nvmupdate

[Tony Nguyen <anthony.l.nguyen@intel.com>]

On 6/12/2024 4:04 AM, Aleksandr Loktionov wrote:

As Przemek has pointed out...

"hot issue" doesn't necessarily carry the same meaning; better to just 
drop that out of the title.

> The bug affects users only at the time when they try to update NVM, and
> only F/W versions that generate errors while nvmupdate. For example X710DA2
> with 0x8000ECB7 F/W is affected, but there are probably more...
> 
> After 230f3d53a547 patch, which should only replace F/W specific error codes

Could you cite the commit in the preferred style of SHA +title?

I'd suggest

'After commit 230f3d53a547 ("i40e: remove i40e_status"),'

Thanks,
Tony

> with Linux kernel generic, all EIO errors started to be converted into EAGAIN
> which leads nvmupdate to retry until it timeouts and sometimes fails after
> more than 20 minutes in the middle of NVM update, so NVM becomes corrupted.
> 
> Remove wrong EIO to EGAIN conversion and pass all errors as is.
> 
> Fixes: 230f3d53a547 ("i40e: remove i40e_status")
> Co-developed-by: Kelvin Kang <kelvin.kang@intel.com>
> Signed-off-by: Kelvin Kang <kelvin.kang@intel.com>
> Reviewed-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>