From: Mat Martineau <martineau@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, donald.hunter@gmail.com, matttbe@kernel.org,
dcaratti@redhat.com, mptcp@lists.linux.dev
Subject: Re: [PATCH net-next 3/3] netlink: specs: mptcp: rename the MPTCP path management(?) spec
Date: Wed, 13 Dec 2023 15:38:18 -0800 (PST) [thread overview]
Message-ID: <03869802-eb14-ed32-e9d7-53b17a74904f@kernel.org> (raw)
In-Reply-To: <20231213232822.2950853-4-kuba@kernel.org>
On Wed, 13 Dec 2023, Jakub Kicinski wrote:
> We assume in handful of places that the name of the spec is
> the same as the name of the family. We could fix that but
> it seems like a fair assumption to make. Rename the MPTCP
> spec instead.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: matttbe@kernel.org
> CC: martineau@kernel.org
> CC: dcaratti@redhat.com
> CC: mptcp@lists.linux.dev
> ---
> Documentation/netlink/specs/{mptcp.yaml => mptcp_pm.yaml} | 0
> include/uapi/linux/mptcp_pm.h | 2 +-
> net/mptcp/mptcp_pm_gen.c | 2 +-
> net/mptcp/mptcp_pm_gen.h | 2 +-
> 4 files changed, 3 insertions(+), 3 deletions(-)
> rename Documentation/netlink/specs/{mptcp.yaml => mptcp_pm.yaml} (100%)
>
Hi Jakub -
The renaming here is fine. "path management" is the right expansion of
"pm" in this context, so you can remove the "(?)" from the summary line.
Reviewed-by: Mat Martineau <martineau@kernel.org>
next prev parent reply other threads:[~2023-12-13 23:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 23:28 [PATCH net-next 0/3] netlink: specs: prep legacy specs for C code gen Jakub Kicinski
2023-12-13 23:28 ` [PATCH net-next 1/3] netlink: specs: ovs: remove fixed header fields from attrs Jakub Kicinski
2023-12-14 8:40 ` Donald Hunter
2023-12-13 23:28 ` [PATCH net-next 2/3] netlink: specs: ovs: correct enum names in specs Jakub Kicinski
2023-12-14 8:45 ` Donald Hunter
2023-12-13 23:28 ` [PATCH net-next 3/3] netlink: specs: mptcp: rename the MPTCP path management(?) spec Jakub Kicinski
2023-12-13 23:38 ` Mat Martineau [this message]
2023-12-14 8:42 ` Donald Hunter
2023-12-14 17:24 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03869802-eb14-ed32-e9d7-53b17a74904f@kernel.org \
--to=martineau@kernel.org \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).