From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpbgau1.qq.com (smtpbgau1.qq.com [54.206.16.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8AF9259C80 for ; Mon, 25 May 2026 01:42:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.206.16.166 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779673381; cv=none; b=n7qaG6O+xLHxLabyIVZC+vIMOsi0kpjlufJwKJK7r7FnKBpM2k1PrADohppOMutZaCvdFDx1QHYoqid6dCKfJN1+tLwnOYMSm9rQb1zT8lM/sO7oAdPph6xUOB2Jmh46Sfmat7U5rI8126t8looQWlL0Pm8OluIftT8Qikv10MM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779673381; c=relaxed/simple; bh=aTEL6UDmN/2y+eRgOarmtXE3AJBoftOubaTcLtzNgbw=; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID: MIME-Version:Content-Type; b=ST9QIxUlIRFuX8L4sXcr5lx6lbYapXTS7dKQ7ViaBa8HZOlBhmA2sqFlv1aJ2twtKYWLmudt/9i7/HjnybKQNfm/TI1DJQM4AM5SutZKiNATHBJiKGcnuEl7uMoLKhLm/NtI36VmgTPYMEU+5MycQIGict4BFMUyeuI9VxvYl9I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=trustnetic.com; spf=pass smtp.mailfrom=trustnetic.com; arc=none smtp.client-ip=54.206.16.166 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=trustnetic.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=trustnetic.com X-QQ-mid:Yeas6t1779673314t961t53775 Received: from 3DB253DBDE8942B29385B9DFB0B7E889 (jiawenwu@trustnetic.com [60.186.246.224]) X-QQ-SSF:0000000000000000000000000000000 From: =?utf-8?b?Smlhd2VuIFd1?= X-BIZMAIL-ID: 12658486668262179054 To: "'Chenguang Zhao'" , "'Mengyuan Lou'" , "'Andrew Lunn'" , "'David S. Miller'" , "'Eric Dumazet'" , "'Jakub Kicinski'" , "'Paolo Abeni'" Cc: "'Simon Horman'" , References: <20260522070749.1634542-1-zhaochenguang@kylinos.cn> In-Reply-To: <20260522070749.1634542-1-zhaochenguang@kylinos.cn> Subject: RE: [net-next] net: txgbe: fix phylink leak on AML init failure Date: Mon, 25 May 2026 09:41:53 +0800 Message-ID: <03b101dcebe7$aa3205d0$fe961170$@trustnetic.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: zh-cn Thread-Index: AQIwUtBzeX57bJtS28N/SAFwNnEPa7V3KTyg X-QQ-SENDSIZE: 520 Feedback-ID: Yeas:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz6b-0 X-QQ-XMAILINFO: OGvgEoGelOUdifqBOiBR/484qYBUuHxZy8BmDhNE1noTub8AUyUMh87O MIipDmKqqE5geLft64KU9TNbmD6jhY2KZsMDar8+z/KHC5kqF1v7BywfQ6FUMFLGN/g2Bgz OBAE3c7+ZdMgYv+tsrILdNEBTF4sslmBHLfpM6L5CJQqlK+H71/DilCS1EfmgRlv1r8s86Q BA/aZhYyhKHTj15zaMUxMBRNZp7GFlx2XW7T+OXFbQy+y+6lukPc+SU8wuv62H82/N1PwJI seyf5nRal9A8XNyS/pmB/zdETudbJSFsdNECCS3FNocqNC0mwoGPznqQdc45tfOBglraJBH LTaR2WgOYZzS724dbwC+MU/1Ie61IMbC1mdKxkj/bJQaTgNfGV05VUA+5pQDnhZY5w81gQi MYOiQihWCdbpAmtSZJAU9qqmBf7pfXRuuixWWsiKFftCdn4nXMJlyejplvW7sAKtN7mgUsZ zjfBUTnTFH0UxjfVtE0aiIkNPIahneOmin+B305tsLyLSDk3oFTQp1oUKg6TRh86n9nW94H Empy4WZC9sacqgF0OIR5cjvLR81Ld/NmKsxd0pjZVrHvF3+lUqB9yxb38Pih1yWYfRw1kV9 6rzLX2Nl8ufyb3+usd59n1Rw4vLglJ0OllvVmFKeUGAtFuRpiKZ7DWmf2ULe5Bw9XqmAPHm VpR4pnKIIvXEFo3olSSeHVZB6ZK6Nago6XKpr9JjCL9WT+cRA0z4m+VlcdlsBdhTHCgj4Nu YNsf0UxjM3rk6UKtiUBBHMAFq6PttyoNGm50xJ1qK1APnG9MOrnauTwL0aVr5r4R/m/oMi9 kYtggwGr1n915o4UXX2RtmxpPdCpThssml5GPNe+DBx/GferVdjBhOOPCoXJRCDoMxPiWIj LNaf32/6TeLtTH/j//cX6DU9ubTR7eZuirgCWNz5MV7tH6852KkMi5YXFbtTyld7G+pp3UF iN+PKnqkmuDV4Ypfkji3vkp2l10RTRaScJuIBilh7pWvMLD2Tny+Qyy8/dV33eUFIjw8irB 3pOu0VNTjeVc72/DIkuzU8nPEchpCXwVRHSyAeS5VOIFzN/mWzSzlBnQHNW5vzC67OZoauw pThi2d2ERbXXpEjBv+v/so= X-QQ-XMRINFO: OWPUhxQsoeAVwkVaQIEGSKwwgKCxK/fD5g== X-QQ-RECHKSPAM: 0 On Fri, May 22, 2026 3:08 PM, Chenguang Zhao wrote: > Destroy the phylink instance when fixed-link setup fails. > > Signed-off-by: Chenguang Zhao > --- > drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c > index f0514251d4f3..8e301e7d1148 100644 > --- a/drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c > +++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c > @@ -521,6 +521,7 @@ int txgbe_phylink_init_aml(struct txgbe *txgbe) > err = phylink_set_fixed_link(phylink, &state); > if (err) { > wx_err(wx, "Failed to set fixed link\n"); > + phylink_destroy(phylink); > return err; > } > Reviewed-by: Jiawen Wu Thanks!