From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 451BBC2D0C2 for ; Fri, 3 Jan 2020 13:31:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 086F42085B for ; Fri, 3 Jan 2020 13:31:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="uT8xCfxs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727636AbgACNbF (ORCPT ); Fri, 3 Jan 2020 08:31:05 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:36044 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727508AbgACNbE (ORCPT ); Fri, 3 Jan 2020 08:31:04 -0500 Received: from epcas5p3.samsung.com (unknown [182.195.41.41]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20200103133101epoutp012e44a6837a77eb28ed5798bfaf4547a2~mY6C5uCTJ0977409774epoutp01B for ; Fri, 3 Jan 2020 13:31:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20200103133101epoutp012e44a6837a77eb28ed5798bfaf4547a2~mY6C5uCTJ0977409774epoutp01B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1578058261; bh=CzotQGxCyi/4dtz9P6CgUOC3NUvi0KvaTzWTnRskAYg=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=uT8xCfxszMH/RX/DN0Sh+TmBRI7lhzvgUeF3cvWzIItJS2a6/mwG8jwmq5orhYWD2 rdhy8Z0v7m1iCoWhYU9Kdof8x7VxgMQCVPmxMI409AkEyn99lN8KAbkUCozpHETh8r w71vpCT2nfcoJN0D+l+Tea/DKT99LhcNUphG/7nw= Received: from epsmges5p2new.samsung.com (unknown [182.195.42.74]) by epcas5p2.samsung.com (KnoxPortal) with ESMTP id 20200103133100epcas5p265f43c43a0ea458a2ac2d01fbe5f156f~mY6COk7nD0816308163epcas5p26; Fri, 3 Jan 2020 13:31:00 +0000 (GMT) Received: from epcas5p2.samsung.com ( [182.195.41.40]) by epsmges5p2new.samsung.com (Symantec Messaging Gateway) with SMTP id F5.46.20197.4124F0E5; Fri, 3 Jan 2020 22:31:00 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas5p4.samsung.com (KnoxPortal) with ESMTPA id 20200103133100epcas5p49bc475820cb614412fb1044c61d6c6fe~mY6B54Ix62781027810epcas5p4_; Fri, 3 Jan 2020 13:31:00 +0000 (GMT) Received: from epsmgms1p2new.samsung.com (unknown [182.195.42.42]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200103133100epsmtrp176dc4f79dacb1dcb472defec5142f6de~mY6B4qCjI1859918599epsmtrp1N; Fri, 3 Jan 2020 13:31:00 +0000 (GMT) X-AuditID: b6c32a4a-781ff70000014ee5-09-5e0f42144144 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p2new.samsung.com (Symantec Messaging Gateway) with SMTP id C4.8A.06569.4124F0E5; Fri, 3 Jan 2020 22:31:00 +0900 (KST) Received: from sriramdash03 (unknown [107.111.85.29]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200103133056epsmtip21282c02fda30a33d35e1e18607224912~mY5_rLsKO0217902179epsmtip2k; Fri, 3 Jan 2020 13:30:56 +0000 (GMT) From: "Sriram Dash" To: "'kernelci.org bot'" , , , "'David S. Miller'" , , , , "'Jayati Sahu'" , "'Padmanabhan Rajanbabu'" , , Cc: , , "'David S. Miller'" , "'Maxime Coquelin'" , , , "'Jose Abreu'" , "'Giuseppe Cavallaro'" , "'Alexandre Torgue'" , , In-Reply-To: <5e0314da.1c69fb81.a7d63.29c1@mx.google.com> Subject: RE: broonie-regmap/for-next bisection: boot on ox820-cloudengines-pogoplug-series-3 Date: Fri, 3 Jan 2020 19:00:55 +0530 Message-ID: <03ca01d5c23a$09921d00$1cb65700$@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Content-Language: en-in Thread-Index: AQHVkLQqlgs7zItKQK6JQygQi6mu7gG5ib8fp8uBzjA= X-Brightmail-Tracker: H4sIAAAAAAAAA02SaUwTURSF8zpLh8rgWCpcITFaJVEUEIPxucQVkwlq1Jj4Qw1SdQLIagfc 4oKKqI0WoxKlQaVKaiQiUssiKktxQQmoCChhMdW6UBeKK7jTDkT+fe/ec955J3kMocyk/ZjY xBRBm6iJV9MKsqRm4oQg1YLhkVO63gfgInsdwo2tVRTOstlpnPMwncSX26wIv/90gcC3H+TJ cOcvJ4X7Dlpk2PyyhcJPynNorGuxU/js7wIKZ3SekmOrfg2+m+uD7xStxOeLv8jx33fFCBse lVFYX9BIzxvJdz87IOfLOvIQb7nUKuOvGzrkvDn/MM3f7PLkr+Xt4fWWfMRXV4Tyr3pvEbyl 8jPiP5tHL/dcrZi9UYiP3SJoQ+ZEKWLq6/LlyZaZ24oKK8g0VByiQx4McGHQ2aJDOqRglNwN BMUfL8ilwycE5nYz6VIpuW8I9FfZQcfrL7UDjlsIch1naEnkQFB5ws00FwT1z/bRLpGK20uA zvRI7loQXAkBH4zrXOzBzYATXU63wZuLBFv3GXcayY2HbFuFW8/2a0prz9ESj4D72XZSumcS mIzvCOlFY6DvlYmS5r5wp++Ie67iZsKPp+fddYDby0Da2xYkGcKhwVFLSewNjnsWucR+0JWZ McBx8ET/ZiAgBU47jKTEc6GqKaefmf6wiVBYHiLlesHRn3aZawwcC4cylJI6ABxt1wZu9Ieq gjqZxDxU1n+VHUNjDUOaGYY0MwxpY/gflovIfDRKSBYTogVxWvLURGFrsKhJEFMTo4M3JCWY kfubBkaUIVPDEiviGKT2ZKPGDY9UUpot4vYEKwKGUKvYrSvYSCW7UbN9h6BNWqdNjRdEK/Jn SLUve5xqXqvkojUpQpwgJAvawa2M8fBLQ2Nipz8IKBpmC3sxRxaI+dzv4aWF8MHre02KuPNS hGlD49iakv1+x4UdhX9iFrcvvPKnur1x/HpFBPPzojM9qSHLdjIUrWx7Prs5blGPcfd8o3mZ Mrt7d9bm0lB2WbiPM1M133k3r+mez6pZK4J7R8zo9lerJvds0gQ93ryrfKlPeoWaFGM0oYGE VtT8AyBZk4WiAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrCIsWRmVeSWpSXmKPExsWy7bCSvK6IE3+cwcd//BYbn5xmtLh08wCr xdSHT9gs5pxvYbFYc/sQo8WbT4uZLY6cWsJkce/PB1aLn+1bmCw2Pb7GanF51xw2i65rT1gt 5v1dy2rRdm86u8WhvmiLYwvELI5uDLZYtPULu8X/11sZLWZd2MFq0bf2EpuDqMf7G63sHjvu LmH02LLyJpPHzll32T02repk89jzksdj85J6j74tqxg9Du4z9Hj6Yy+zx5b9nxk9Pm+SC+CJ 4rJJSc3JLEst0rdL4Mr4ueohU8EKy4oD0/4xNTAu1Oti5OSQEDCRePblBGMXIxeHkMBuRonH R3axdTFyACWkJX7e1YWoEZZY+e85O0TNC0aJDY1PWEASbAK6EmdvNLGBJEQEupklfr/+zwSS YBbYxyxx4XQKREcXo8SKBY1gCU4BS4nJLz+wgdjCAjESp65cYAexWQRUJGY+3Adm8wLVbD8x nw3CFpQ4ORNiG7OAtsTTm0/h7GULXzNDnKcg8fPpMlaIuLjE0Z89YHERASuJX9cXsU9gFJ6F ZNQsJKNmIRk1C0n7AkaWVYySqQXFuem5xYYFRnmp5XrFibnFpXnpesn5uZsYwWlBS2sH44kT 8YcYBTgYlXh4E5T544RYE8uKK3MPMUpwMCuJ8JYH8sYJ8aYkVlalFuXHF5XmpBYfYpTmYFES 55XPPxYpJJCeWJKanZpakFoEk2Xi4JRqYJQKrdlW2VPy8VfUlqdntpw6WFdopxV30G3y1tsC xxvlLigvZbxv83UPC8fRNzbr5pZt9C6Z9mPRvrrv5fp5rS59Dj5/Xq1tLJ++7KnXCceer9Nz r+yV7k4yYH/jvY3jaFilbuS/c+Llux5uODz/zq44i5LjTOGPWeUiFCp9Pr77c/n6yleLvSco sRRnJBpqMRcVJwIAGq7YXAcDAAA= X-CMS-MailID: 20200103133100epcas5p49bc475820cb614412fb1044c61d6c6fe X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" CMS-TYPE: 105P X-CMS-RootMailID: 20191225075056epcas4p2ab51fc6ff1642705a61f906189bb29f0 References: <5e0314da.1c69fb81.a7d63.29c1@mx.google.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > From: kernelci.org bot > Subject: broonie-regmap/for-next bisection: boot on ox820-cloudengines- > pogoplug-series-3 >=20 > * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * > * This automated bisection report was sent to you on the basis * > * that you may be involved with the breaking commit it has * > * found. No manual investigation has been done to verify it, * > * and the root cause of the problem may be somewhere else. * > * * > * If you do send a fix, please include this trailer: * > * Reported-by: =22kernelci.org bot=22 * > * * > * Hope this helps=21 * > * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * >=20 > broonie-regmap/for-next bisection: boot on ox820-cloudengines-pogoplug- > series-3 >=20 > Summary: > Start: 46cf053efec6 Linux 5.5-rc3 > Details: https://protect2.fireeye.com/url?k=3D36fb52ed-6b2b5a21-36fa= d9a2- > 000babff3793- > f64e7c227e0a8b34&u=3Dhttps://kernelci.org/boot/id/5e02ce65451524462f9731 > 4f > Plain log: https://protect2.fireeye.com/url?k=3D58f5fc3b-0525f4f7-58f4= 7774- > 000babff3793-f96a18481add0d7f&u=3Dhttps://storage.kernelci.org//broonie- > regmap/for-next/v5.5-rc3/arm/oxnas_v6_defconfig/gcc-8/lab- > baylibre/boot-ox820-cloudengines-pogoplug-series-3.txt > HTML log: https://protect2.fireeye.com/url?k=3Deaed2629-b73d2ee5- > eaecad66-000babff3793- > 84ba1e41025b4f73&u=3Dhttps://storage.kernelci.org//broonie-regmap/for- > next/v5.5-rc3/arm/oxnas_v6_defconfig/gcc-8/lab-baylibre/boot-ox820- > cloudengines-pogoplug-series-3.html > Result: d3e014ec7d5e net: stmmac: platform: Fix MDIO init for platf= orms > without PHY >=20 > Checks: > revert: PASS > verify: PASS >=20 > Parameters: > Tree: broonie-regmap > URL: > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git > Branch: for-next > Target: ox820-cloudengines-pogoplug-series-3 > CPU arch: arm > Lab: lab-baylibre > Compiler: gcc-8 > Config: oxnas_v6_defconfig > Test suite: boot >=20 > Breaking commit found: >=20 > -------------------------------------------------------------------------= ------ > commit d3e014ec7d5ebe9644b5486bc530b91e62bbf624 > Author: Padmanabhan Rajanbabu > Date: Thu Dec 19 15:47:01 2019 +0530 >=20 > net: stmmac: platform: Fix MDIO init for platforms without PHY >=20 > The current implementation of =22stmmac_dt_phy=22 function initialize= s > the MDIO platform bus data, even in the absence of PHY. This fix > will skip MDIO initialization if there is no PHY present. >=20 > Fixes: 7437127 (=22net: stmmac: Convert to phylink and remove phylib = logic=22) > Acked-by: Jayati Sahu > Signed-off-by: Sriram Dash > Signed-off-by: Padmanabhan Rajanbabu > Signed-off-by: David S. Miller >=20 > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > index bedaff0c13bd..cc8d7e7bf9ac 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > =40=40 -320,7 +320,7 =40=40 static int stmmac_mtl_setup(struct platform_d= evice > *pdev, static int stmmac_dt_phy(struct plat_stmmacenet_data *plat, > struct device_node *np, struct device *dev) =7B > - bool mdio =3D true; > + bool mdio =3D false; > static const struct of_device_id need_mdio_ids=5B=5D =3D =7B > =7B .compatible =3D =22snps,dwc-qos-ethernet-4.10=22 =7D, > =7B=7D, > -------------------------------------------------------------------------= ------ >=20 >=20 > Git bisection log: >=20 > -------------------------------------------------------------------------= ------ > git bisect start > =23 good: =5Be42617b825f8073569da76dc4510bfa019b1c35a=5D Linux 5.5-rc1 gi= t > bisect good e42617b825f8073569da76dc4510bfa019b1c35a > =23 bad: =5B46cf053efec6a3a5f343fead837777efe8252a46=5D Linux 5.5-rc3 git= bisect > bad 46cf053efec6a3a5f343fead837777efe8252a46 > =23 good: =5B2187f215ebaac73ddbd814696d7c7fa34f0c3de0=5D Merge tag 'for-5= .5- > rc2-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux > git bisect good 2187f215ebaac73ddbd814696d7c7fa34f0c3de0 > =23 good: =5B0dd1e3773ae8afc4bfdce782bdeffc10f9cae6ec=5D pipe: fix empty = pipe > check in pipe_write() git bisect good > 0dd1e3773ae8afc4bfdce782bdeffc10f9cae6ec > =23 good: =5B040cda8a15210f19da7e29232c897ca6ca6cc950=5D Merge tag 'wirel= ess- > drivers-2019-12-17' of > git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers > git bisect good 040cda8a15210f19da7e29232c897ca6ca6cc950 > =23 bad: =5B4bfeadfc0712bbc8a6556eef6d47cbae1099dea3=5D Merge branch 'sfc= - > fix-bugs-introduced-by-XDP-patches' > git bisect bad 4bfeadfc0712bbc8a6556eef6d47cbae1099dea3 > =23 good: =5B0fd260056ef84ede8f444c66a3820811691fe884=5D Merge > git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf > git bisect good 0fd260056ef84ede8f444c66a3820811691fe884 > =23 good: =5B90b3b339364c76baa2436445401ea9ade040c216=5D net: hisilicon: = Fix a > BUG trigered by wrong bytes_compl git bisect good > 90b3b339364c76baa2436445401ea9ade040c216 > =23 bad: =5B4c8dc00503db24deaf0b89dddfa84b7cba7cd4ce=5D qede: Disable > hardware gro when xdp prog is installed git bisect bad > 4c8dc00503db24deaf0b89dddfa84b7cba7cd4ce > =23 bad: =5B28a3b8408f70b646e78880a7eb0a97c22ace98d1=5D net/smc: unregist= er > ib devices in reboot_event git bisect bad > 28a3b8408f70b646e78880a7eb0a97c22ace98d1 > =23 bad: =5Bd3e014ec7d5ebe9644b5486bc530b91e62bbf624=5D net: stmmac: > platform: Fix MDIO init for platforms without PHY git bisect bad > d3e014ec7d5ebe9644b5486bc530b91e62bbf624 > =23 good: =5Baf1c0e4e00f3cc76cb136ebf2e2c04e8b6446285=5D llc2: Fix return > statement of llc_stat_ev_rx_null_dsap_xid_c (and _test_c) git bisect good > af1c0e4e00f3cc76cb136ebf2e2c04e8b6446285 > =23 first bad commit: =5Bd3e014ec7d5ebe9644b5486bc530b91e62bbf624=5D net: > stmmac: platform: Fix MDIO init for platforms without PHY > -------------------------------------------------------------------------= ------ The mdio bus will be allocated in case of a phy transceiver is on board, bu= t if fixed-link is configured, it will be NULL and of_mdiobus_register will not take effect. The commit d3e014ec7d5e fixes the code for fixed-link configuration. However, some platforms like oxnas820 which have phy transceivers (rgmii), fail. This is because the platforms expect the alloca= tion of mdio_bus_data during stmmac_dt_phy.=20 Proper solution to this is adding the mdio node in the device tree of the platform which can be fetched by stmmac_dt_phy. A rough addition to the Ethernet node can be as follows: pinctrl-names =3D =22default=22; pinctrl-0 =3D <&pinctrl_etha_mdio>; + mdio =7B + compatible =3D =22snps,dwmac-mdio=22; + =23address-cells =3D <1>; + =23size-cells =3D <0>; + =7D; =7D;