From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Shinas Rasheed <srasheed@marvell.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: hgani@marvell.com, sedara@marvell.com, vimleshk@marvell.com,
thaller@redhat.com, wizhao@redhat.com, kheib@redhat.com,
egallen@redhat.com, konguyen@redhat.com, horms@kernel.org,
Veerasenareddy Burru <vburru@marvell.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Abhijit Ayarekar <aayarekar@marvell.com>,
Satananda Burla <sburla@marvell.com>
Subject: Re: [PATCH net v4 1/7] octeon_ep: Add checks to fix double free crashes
Date: Wed, 13 Nov 2024 22:38:53 +0000 [thread overview]
Message-ID: <03ccdc24-27af-4b4e-baf3-40d89ae72e99@linux.dev> (raw)
In-Reply-To: <20241113111319.1156507-2-srasheed@marvell.com>
On 13/11/2024 11:13, Shinas Rasheed wrote:
> From: Vimlesh Kumar <vimleshk@marvell.com>
>
> Add required checks to avoid double free. Crashes were
> observed due to the same on reset scenarios, when reset
> was tried multiple times, and the first reset had torn
> down resources already.
I'm looking at the whole series and it feels like we have to deal
with the root cause rather than add protective code left and right.
The driver may potentially have some locks missing which will cause
missing resources, and to fix the root cause these locks have to be
added. WDYT?
next prev parent reply other threads:[~2024-11-13 22:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 11:13 [PATCH net v4 0/7] Double free fixes and NULL pointer checks Shinas Rasheed
2024-11-13 11:13 ` [PATCH net v4 1/7] octeon_ep: Add checks to fix double free crashes Shinas Rasheed
2024-11-13 14:59 ` Vadim Fedorenko
2024-11-13 22:38 ` Vadim Fedorenko [this message]
2024-11-16 17:25 ` [EXTERNAL] " Shinas Rasheed
2024-11-13 11:13 ` [PATCH net v4 2/7] octeon_ep: Fix null dereferences to IQ/OQ pointers Shinas Rasheed
2024-11-13 11:13 ` [PATCH net v4 3/7] octeon_ep: add protective null checks in napi callbacks for cn9k cards Shinas Rasheed
2024-11-13 17:59 ` Vadim Fedorenko
2024-11-13 11:13 ` [PATCH net v4 4/7] octeon_ep: add protective null checks in napi callbacks for cnxk cards Shinas Rasheed
2024-11-13 18:01 ` Vadim Fedorenko
2024-11-13 11:13 ` [PATCH net v4 5/7] octeon_ep_vf: Fix null dereferences to IQ/OQ pointers Shinas Rasheed
2024-11-13 11:13 ` [PATCH net v4 6/7] octeon_ep_vf: add protective null checks in napi callbacks for cn9k cards Shinas Rasheed
2024-11-13 18:02 ` Vadim Fedorenko
2024-11-13 11:13 ` [PATCH net v4 7/7] octeon_ep_vf: add protective null checks in napi callbacks for cnxk cards Shinas Rasheed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03ccdc24-27af-4b4e-baf3-40d89ae72e99@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=aayarekar@marvell.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=egallen@redhat.com \
--cc=hgani@marvell.com \
--cc=horms@kernel.org \
--cc=kheib@redhat.com \
--cc=konguyen@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sburla@marvell.com \
--cc=sedara@marvell.com \
--cc=srasheed@marvell.com \
--cc=thaller@redhat.com \
--cc=vburru@marvell.com \
--cc=vimleshk@marvell.com \
--cc=wizhao@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).