Re: [net-next PATCH v4 7/8] net: dsa: realtek: rtl8365mb: add FDB support

[Mieczyslaw Nalewaj <namiltd@yahoo.com>]

On 5/16/2026 5:46 AM, Luiz Angelo Daros de Luca wrote:
> From: Alvin Å ipraga <alsi@bang-olufsen.dk>
> 
> Implement support for FDB and MDB management for the RTL8365MB series
> switches.
> 
> The hardware supports IVL by keying the forwarding database with the
> {VID, MAC, EFID} tuple.  The Extended Filtering ID (EFID) is 3 bits
> wide, providing 8 unique filtering domains. This driver reserves EFID 0
> for standalone ports, effectively limiting the hardware offload to a
> maximum of 7 bridges.
> 
> Introduce a mutex lock (l2_lock) to protect concurrent L2 table updates.
> 
> Add support for forwarding database operations, including unicast and
> multicast entry handling as well as fast aging support.
> 
> Set DSA switch flags assisted_learning_on_cpu_port and fdb_isolation.
> 
> Co-developed-by: Alvin Å ipraga <alsi@bang-olufsen.dk>
> Signed-off-by: Alvin Å ipraga <alsi@bang-olufsen.dk>
> Reviewed-by: Linus Walleij <linusw@kernel.org>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
> ---
> [ ... ]
> +
> +struct rtl8365mb_l2_mc_key {
> +	u8 mac_addr[ETH_ALEN];
> +	union {
> +		u16 vid; /* IVL */
> +		u16 fid; /* SVL */
> +	};
> +	bool ivl;
> +};
> +
> +struct rtl8365mb_l2_mc {
> +	struct rtl8365mb_l2_mc_key key;
> +	u16 member;
> +	u8 priority;
> +	u8 igmpidx;
> +
> +	bool is_static;
> +	bool fwd_pri;
> +	bool igmp_asic;
> +};
> +
> +static void rtl8365mb_l2_data_to_uc(const u16 *data, struct rtl8365mb_l2_uc *uc)
> +{
> +	u32 val;
> +
> +	uc->key.mac_addr[5] = FIELD_GET(RTL8365MB_L2_UC_D0_MAC5_MSK, data[0]);
> +	uc->key.mac_addr[4] = FIELD_GET(RTL8365MB_L2_UC_D0_MAC4_MSK, data[0]);
> +	uc->key.mac_addr[3] = FIELD_GET(RTL8365MB_L2_UC_D1_MAC3_MSK, data[1]);
> +	uc->key.mac_addr[2] = FIELD_GET(RTL8365MB_L2_UC_D1_MAC2_MSK, data[1]);
> +	uc->key.mac_addr[1] = FIELD_GET(RTL8365MB_L2_UC_D2_MAC1_MSK, data[2]);
> +	uc->key.mac_addr[0] = FIELD_GET(RTL8365MB_L2_UC_D2_MAC0_MSK, data[2]);
> +	uc->key.efid = FIELD_GET(RTL8365MB_L2_UC_D4_EFID_MSK, data[4]);
> +	uc->key.vid = FIELD_GET(RTL8365MB_L2_UC_D3_VID_MSK, data[3]);
> +	uc->key.ivl = FIELD_GET(RTL8365MB_L2_UC_D3_IVL_MSK, data[3]);
> +	uc->key.fid = FIELD_GET(RTL8365MB_L2_UC_D4_FID_MSK, data[4]);
> +	uc->age = FIELD_GET(RTL8365MB_L2_UC_D4_AGE_MSK, data[4]);
> +	uc->auth = FIELD_GET(RTL8365MB_L2_UC_D4_AUTH_MSK, data[4]);
> +

The problem with overwriting uc->key.fid and uc->key.vid values in the union still exists.