Re: [PATCH net v2 0/2] ionic: fix port_info lifetime bugs

[Eric Joyner <eric.joyner@amd.com>]

On 10/15/2026 4:08 PM, netdev-bot+sinfo@kernel.org wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> Hi!
> 
> This is an automated message. This series looks like a fix, but its
> commit messages seem to be missing some information:
> 
>  - How the issue was discovered, e.g. hit in production, hit during
>    development, syzbot report, manual code inspection, LLM or static
>    analysis tool scan.
> 
>  - Whether the issue was actually triggered, or is only theoretical
>    (e.g. found by code inspection). If it was triggered please include
>    the symptoms, like the stack trace or error messages.
> 
>  - What hardware the change was tested on. For driver fixes please
>    mention the device (and if relevant firmware version) used for
>    testing, or say that the change was not tested on real hardware.
> 
> Please do not repost the series just to address the above. Instead,
> reply to this email with the missing information, so that reviewers
> can take it into account. If the series needs another revision for
> other reasons, please include the information in the commit messages
> then.
> 
> The evaluation is done by an LLM so it may be wrong, if you think
> that is the case please reply and explain.

Ok:

- This was discovered by a Sashiko review for v1 of a different patchset;
we evaluated the discovery internally and it looked like something that
should be fixed.

- It's theoretical by finding, but...

- I tested it on an actual DSC3 "Pollara" with a hacked driver and test kernel
to cause both issues:
  - Had PORT_INIT fail during PCI reset recovery and saw that the port_info
buffer was freed while the netdev was still registered, meaning that the netdev
ethtool ops could get a NULL pointer for port_info
  - Made probe fail on purpose at ionic_setup_one() to verify that port_info
memory and DMA allocation was being leaked

  and then checked that the patched one did not have these issues.

- Eric