Netdev List
 help / color / mirror / Atom feed
From: Moshe Shemesh <moshe@nvidia.com>
To: Alexandre Cassen <acassen@corp.free.fr>,
	Saeed Mahameed <saeedm@nvidia.com>,
	Leon Romanovsky <leon@kernel.org>,
	Tariq Toukan <tariqt@nvidia.com>, Mark Bloch <mbloch@nvidia.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Yevgeny Kliteynik <kliteyn@nvidia.com>, <netdev@vger.kernel.org>,
	<linux-rdma@vger.kernel.org>
Subject: Re: [PATCH net 2/2] net/mlx5: HWS, fix flow meter offset within its bulk
Date: Thu, 8 Oct 2026 18:59:51 +0300	[thread overview]
Message-ID: <03f7a3ae-e223-48bb-bd4c-3a12288257b0@nvidia.com> (raw)
In-Reply-To: <20261007143830.1733583-3-acassen@corp.free.fr>



On 10/7/2026 5:38 PM, Alexandre Cassen wrote:
> 
> The flow meter action is bound to the first ASO object of the bulk but
> the rule offset only indexes the meter within its own object. A rule
> past the first object runs on the wrong meter.
> 
> Fixes: 82d3639ef7dc ("net/mlx5: fs, add support for flow meters HWS action")
> Signed-off-by: Alexandre Cassen <acassen@corp.free.fr>

Reviewed-by: Moshe Shemesh <moshe@nvidia.com>

Thanks.
> ---
>   drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c
> index 44b311b4532d..54761754e657 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c
> @@ -928,6 +928,7 @@ static int mlx5_fs_fte_get_hws_actions(struct mlx5_flow_root_namespace *ns,
>                          goto free_actions;
>                  }
>                  (*ractions)[num_actions].aso_meter.offset =
> +                       (fte_action->exe_aso.object_id - fte_action->exe_aso.base_id) * 2 +
>                          fte_action->exe_aso.flow_meter.meter_idx;
>                  (*ractions)[num_actions].aso_meter.init_color =
>                          fte_action->exe_aso.flow_meter.init_color;
> --
> 2.43.0
> 


  reply	other threads:[~2026-10-08 16:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-07 14:38 [PATCH net 0/2] net/mlx5: HWS, fix reformat release and meter offset Alexandre Cassen
2026-10-07 14:38 ` [PATCH net 1/2] net/mlx5: HWS, release L2 to L3 tunnel reformats to their own pool Alexandre Cassen
2026-10-08 13:32   ` Yevgeny Kliteynik
2026-10-07 14:38 ` [PATCH net 2/2] net/mlx5: HWS, fix flow meter offset within its bulk Alexandre Cassen
2026-10-08 15:59   ` Moshe Shemesh [this message]
2026-10-07 14:44 ` [PATCH net 0/2] net/mlx5: HWS, fix reformat release and meter offset netdev-bot+sinfo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=03f7a3ae-e223-48bb-bd4c-3a12288257b0@nvidia.com \
    --to=moshe@nvidia.com \
    --cc=acassen@corp.free.fr \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=kliteyn@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mbloch@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=saeedm@nvidia.com \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox