From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>, brouer@redhat.com
Cc: eric.dumazet@gmail.com, hkallweit1@gmail.com,
nic_swsd@realtek.com, netdev@vger.kernel.org,
ecree@solarflare.com
Subject: Re: [PATCH net-next] r8169: use netif_receive_skb_list batching
Date: Mon, 1 Apr 2019 14:33:21 -0700 [thread overview]
Message-ID: <04146a4c-a643-34cc-1b58-72b4b3432a25@gmail.com> (raw)
In-Reply-To: <20190401.104120.332857372325942809.davem@davemloft.net>
On 04/01/2019 10:41 AM, David Miller wrote:
> From: Jesper Dangaard Brouer <brouer@redhat.com>
>>
>> As Eric says, this in-effect disables GRO for this driver.
>
> Really? __netif_receive_skb_list_core() does GRO.
At least on current public trees, it can not do GRO,
since we do not pass a napi context.
next prev parent reply other threads:[~2019-04-01 21:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-31 13:18 [PATCH net-next] r8169: use netif_receive_skb_list batching Heiner Kallweit
2019-03-31 18:11 ` David Miller
2019-04-01 9:17 ` Eric Dumazet
2019-04-01 12:53 ` Jesper Dangaard Brouer
2019-04-01 17:41 ` David Miller
2019-04-01 21:33 ` Eric Dumazet [this message]
2019-04-01 17:14 ` David Miller
2019-04-01 17:31 ` Edward Cree
2019-04-01 17:39 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04146a4c-a643-34cc-1b58-72b4b3432a25@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).