From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE213C43381 for ; Mon, 1 Apr 2019 21:33:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AF5ED20857 for ; Mon, 1 Apr 2019 21:33:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Qvbfq7+q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725991AbfDAVd1 (ORCPT ); Mon, 1 Apr 2019 17:33:27 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:33000 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725869AbfDAVd1 (ORCPT ); Mon, 1 Apr 2019 17:33:27 -0400 Received: by mail-wm1-f66.google.com with SMTP id z6so909322wmi.0 for ; Mon, 01 Apr 2019 14:33:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=LIf4uoledS21T1RcvdNHr+rXVCAolS0Fkm/wu1AEKio=; b=Qvbfq7+qAeH0MCGPxxqturwEWAiVHYP6C9TqKvx430u8U4+DyXl6G4FQDDy6pIooiw 9W/IDkP1rfhZeH0GR7Df3hUeXHIvqr7llNAhFjAlUdvsB10RzzMeXymYFdBkSjstzml+ ad6Jw4UUzD9fM/6BHybXJlVli0rBO9M5Ny8i4tWfaIlU0+F+tp5xodPoAipi5a5TIwuB LCqVVOAxr2Lwf8k5N4EHrBQAkGw2ASVVQ5TbhYz8038KN3ajmg0OA1ETfuUfYrmcdpKN B+8Yi3w0eRRLquxsgeDh9s28JDZrRu3i6H/VqiDqPCJgROgn14PfbvOiXFTchlWs5Z99 Ugtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LIf4uoledS21T1RcvdNHr+rXVCAolS0Fkm/wu1AEKio=; b=mjVAMTZrGgCu8L7AChrgPcItjyNchpvoVd83PAgdB24Glk/4gdMlg754+yBVz/WoeZ Gpo90vdLnhMVNefcVtg3wa/O+On3gmD1+MZLWRGtDFemsgiZsVMi/0PzmHI2Nf6F3bVQ IsCpjajJStimT4tA8qMNz5Hyi5CW2lS3QYm2b++oMT/2BCPV3ozlOJXjigDOMwBJ+GHu CXWoKYJ8H/Ai4XEDniLZXkc07P1cfZdHsKw/jl0FhodU0oT0u1BxKpWJiVZSJiyL3+yb bv7k8FHgITOVJVWfCFho7ksVIOJCjpTiBP31JLNu3grvAJVivSvQMCP1EC7zwqkT1Q43 VYlg== X-Gm-Message-State: APjAAAWJ5y9II85I1r9UJzTvDxYe5Y0YekYfNfwsid/7SbPOWw4J9Q6c ofsuH1UpQlE8lecyOYwFo6Y= X-Google-Smtp-Source: APXvYqzpVZUFH2sIjCeDDebmBYc/2mBRgGuvfZ6lIplM1on12AVlFziurnoA7lvgRvOMH5BY3grA5Q== X-Received: by 2002:a7b:c00b:: with SMTP id c11mr1042708wmb.23.1554154405504; Mon, 01 Apr 2019 14:33:25 -0700 (PDT) Received: from [192.168.8.147] (180.250.23.93.rev.sfr.net. [93.23.250.180]) by smtp.gmail.com with ESMTPSA id r30sm26975508wrr.46.2019.04.01.14.33.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Apr 2019 14:33:24 -0700 (PDT) Subject: Re: [PATCH net-next] r8169: use netif_receive_skb_list batching To: David Miller , brouer@redhat.com Cc: eric.dumazet@gmail.com, hkallweit1@gmail.com, nic_swsd@realtek.com, netdev@vger.kernel.org, ecree@solarflare.com References: <20190331.111114.1510038068515936853.davem@davemloft.net> <61e68943-fb2c-ff89-90e6-1d2742c56687@gmail.com> <20190401145326.0196c746@carbon> <20190401.104120.332857372325942809.davem@davemloft.net> From: Eric Dumazet Message-ID: <04146a4c-a643-34cc-1b58-72b4b3432a25@gmail.com> Date: Mon, 1 Apr 2019 14:33:21 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190401.104120.332857372325942809.davem@davemloft.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 04/01/2019 10:41 AM, David Miller wrote: > From: Jesper Dangaard Brouer >> >> As Eric says, this in-effect disables GRO for this driver. > > Really? __netif_receive_skb_list_core() does GRO. At least on current public trees, it can not do GRO, since we do not pass a napi context.