From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Samudrala, Sridhar" Subject: Re: [PATCH net] failover: eliminate callback hell Date: Mon, 11 Jun 2018 12:34:18 -0700 Message-ID: <04210bba-f67a-dd10-cdce-c7d140dcecbe@intel.com> References: <20180605034231.31610-1-sthemmin@microsoft.com> <20180611210819-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kys@microsoft.com, haiyangz@microsoft.com, davem@davemloft.net, netdev@vger.kernel.org, Stephen Hemminger To: "Michael S. Tsirkin" , Stephen Hemminger Return-path: Received: from mga02.intel.com ([134.134.136.20]:18253 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932230AbeFKTeU (ORCPT ); Mon, 11 Jun 2018 15:34:20 -0400 In-Reply-To: <20180611210819-mutt-send-email-mst@kernel.org> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 6/11/2018 11:10 AM, Michael S. Tsirkin wrote: > On Mon, Jun 04, 2018 at 08:42:31PM -0700, Stephen Hemminger wrote: >> * Set permanent and current address of net_failover device >> to match the primary. >> >> * Carrier should be marked off before registering device >> the net_failover device. > Sridhar, do we want to address this? > If yes, could you please take a look at addressing these > meanwhile, while we keep arguing about making API changes? Sure. I will submit patches to address these issues raised by Stephen.