From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18F57405ACA; Thu, 26 Mar 2026 15:24:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774538681; cv=none; b=V7+Y4hz3lO2JyPsq6K1rb8pS3MT9Or09Q2tCmxtpZdbgpmDjhUOXhAM2IveaZtaIpJB763D/IgVfql0fi53hxKSC6pm2eWafiY4ishrFdQlByJpseNmFuLDBV+gOmS61926nU016njWZ8SmiMjjudcTXX7W79AP42wfcb5iI1PU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774538681; c=relaxed/simple; bh=/mgXAcvJTZN55Rw6eRGhfsII3E2iPLsWEYwGCvqKlXI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sew3S/+LI8+ydk63hdjXjhF/xsc0qBYfxr9IoIzXVN0CkQqfAC94y9frRnIp+kcb5nSH+nu1kDFAXrJ6YDiBA5HOURewjc3SqjmrLmWFMtpm6nD6YRZ3MKatSUVPyu3hBi9bgv8xQ4Mb/hsUhJMbHXtZPMcbXU0CKY4DT/RYBck= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=AtNy/DLH; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="AtNy/DLH" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=yqjbpiDcHC6AwPh2QC2yHN18vthccDIXI82Vxclmimg=; b=AtNy/DLHjEfyeQ9EHXJqWyK++U pzDjpjsmSM+vpt7k01cyb4YN4Jqz8qvVR1fHpZ8YaKItFJGkZakuYryCR3Rk9RgHHaf+khxUjynvR yaQ0rdqc4YwIp9ekJQ0aZfk14y8AFjkiM6FJ9t9BNajKuLC67P/u1sN7kjCkKptyJraY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1w5mZL-00DV6x-Ea; Thu, 26 Mar 2026 16:24:23 +0100 Date: Thu, 26 Mar 2026 16:24:23 +0100 From: Andrew Lunn To: "Russell King (Oracle)" Cc: Andrew Lunn , Louis-Alexis Eyraud , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , AngeloGioacchino Del Regno , Heiner Kallweit , kevin-kw.huang@airoha.com, macpaul.lin@mediatek.com, matthias.bgg@gmail.com, kernel@collabora.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 4/4] net: phy: Introduce Airoha AN8801/R Gigabit Ethernet PHY driver Message-ID: <044110c5-da1e-48c0-93fd-35553e86b271@lunn.ch> References: <20260326-add-airoha-an8801-support-v2-0-1a42d6b6050f@collabora.com> <20260326-add-airoha-an8801-support-v2-4-1a42d6b6050f@collabora.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Mar 26, 2026 at 03:13:19PM +0000, Russell King (Oracle) wrote: > On Thu, Mar 26, 2026 at 01:04:15PM +0100, Louis-Alexis Eyraud wrote: > > +static int an8801r_set_wol(struct phy_device *phydev, > > + struct ethtool_wolinfo *wol) > > +{ > > + struct net_device *attach_dev = phydev->attached_dev; > > + const unsigned char *macaddr = attach_dev->dev_addr; > > This isn't a criticism for this patch, but a discussion point for > phylib itself. > > It occurs to me that there's a weakness in the phylib interface for WoL, > specifically when WoL is enabled at the PHY, but someone then changes > the interface's MAC address - there doesn't seem to be a way for the > address programmed into the PHY to be updated. Should there be? > > Do we instead expect users to disable WoL before changing the MAC for > a network interface? Program the MAC address during suspend? I assume userspace is no longer active at this point, so the address should be stable. Andrew