From: Allison Henderson <achender@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, pabeni@redhat.com, edumazet@google.com,
horms@kernel.org, linux-kselftest@vger.kernel.org,
shuah@kernel.org
Subject: Re: [PATCH net-next v1 0/3] selftests: rds: ROCE support follow ups
Date: Fri, 22 May 2026 19:26:46 -0700 [thread overview]
Message-ID: <0463a0ef38073c92d34201c7d0b4ff3ba69934ae.camel@kernel.org> (raw)
In-Reply-To: <20260522191423.3ade3031@kernel.org>
On Fri, 2026-05-22 at 19:14 -0700, Jakub Kicinski wrote:
> On Fri, 22 May 2026 18:19:35 -0700 Allison Henderson wrote:
> > On Fri, 2026-05-22 at 17:46 -0700, Jakub Kicinski wrote:
> > > On Fri, 22 May 2026 14:54:27 -0700 Allison Henderson wrote:
> > > > This is a follow up series to the "Add ROCE support to rds selftests"
> > > > series. The first patch renames run.sh to rds_run.sh, and also adds
> > > > two wrappers to the TEST_PROGS target to run the same test over the
> > > > rdma and tcp transports. The wrappers rds_rdma_run.sh and
> > > > rds_tcp_run.sh also provide self-describing names that appear on the
> > > > netdev CI dashboard.
> > >
> > > Could you make the RDMA test return XFAIL rather than skip when RXE
> > > is not available? We try to use SKIP for cases which are easy to
> > > fix, like a tool missing. We won't be running RDMA tests in netdev..
> >
> > Sure, if you want I could also drop the wrappers since rds_run.sh defaults to tcp.
> > Then patch 1 would just be a rename. Let me know what you prefer.
>
> Dropping the new wrapper SGTM. But IIRC Matthieu suggested the split,
> we should let him also chime in.
Sure, the initial suggestion as a rename, and then I added the wrappers. I will wait for more folks to chime in though.
Allison
prev parent reply other threads:[~2026-05-23 2:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 21:54 [PATCH net-next v1 0/3] selftests: rds: ROCE support follow ups Allison Henderson
2026-05-22 21:54 ` [PATCH net-next v1 1/3] selftests: rds: add per-transport run wrappers Allison Henderson
2026-05-22 21:54 ` [PATCH net-next v1 2/3] selftests: rds: pin RDS sockets to their intended transport Allison Henderson
2026-05-22 21:54 ` [PATCH net-next v1 3/3] selftests: rds: support RDS built as loadable modules Allison Henderson
2026-05-23 0:46 ` [PATCH net-next v1 0/3] selftests: rds: ROCE support follow ups Jakub Kicinski
2026-05-23 1:19 ` Allison Henderson
2026-05-23 2:14 ` Jakub Kicinski
2026-05-23 2:26 ` Allison Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0463a0ef38073c92d34201c7d0b4ff3ba69934ae.camel@kernel.org \
--to=achender@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox