From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Andrew Lunn'" <andrew@lunn.ch>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <rmk+kernel@armlinux.org.uk>,
<netdev@vger.kernel.org>, <mengyuanlou@net-swift.com>,
<duanqiangwen@net-swift.com>
Subject: RE: [PATCH net 2/5] net: wangxun: fix error statistics when the device is reset
Date: Wed, 24 Apr 2024 15:53:17 +0800 [thread overview]
Message-ID: <046501da961c$77f3fba0$67dbf2e0$@trustnetic.com> (raw)
In-Reply-To: <ff606ace-1128-4d16-8192-7ff1a40301af@lunn.ch>
On Tue, April 16, 2024 10:56 PM, Andrew Lunn wrote:
> On Tue, Apr 16, 2024 at 02:29:49PM +0800, Jiawen Wu wrote:
> > Add flag for reset state to avoid reading statistics when hardware
> > is reset.
>
> This explains the what, which you can also get by reading the code
> change. The commit message should also explain the why? What goes
> wrong if you read the statistics when the hardware is in reset? Do you
> get 42 for every statistic? Does the hardware lockup and the reset
> never completes?
I think I should discard this patch, and add the resetting flag to the patch 5/5 to avoid
device reset collision. Since wx_update_stats() is called in txgbe_disable_device() while
device is resetting. And I haven't found a situation that causes statistics confusion.
next prev parent reply other threads:[~2024-04-24 7:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 6:29 [PATCH net 0/5] Wangxun fixes Jiawen Wu
2024-04-16 6:29 ` [PATCH net 1/5] net: wangxun: fix the incorrect display of queue number in statistics Jiawen Wu
2024-04-16 10:16 ` Francois Romieu
2024-04-16 6:29 ` [PATCH net 2/5] net: wangxun: fix error statistics when the device is reset Jiawen Wu
2024-04-16 10:17 ` Francois Romieu
2024-04-16 14:56 ` Andrew Lunn
2024-04-24 7:53 ` Jiawen Wu [this message]
2024-04-16 6:29 ` [PATCH net 3/5] net: wangxun: fix to change Rx features Jiawen Wu
2024-04-16 15:01 ` Andrew Lunn
2024-04-16 6:29 ` [PATCH net 4/5] net: wangxun: change NETIF_F_HW_VLAN_STAG_* to fixed features Jiawen Wu
2024-04-18 18:58 ` Simon Horman
2024-04-25 6:53 ` Jiawen Wu
2024-04-26 7:07 ` Simon Horman
2024-04-16 6:29 ` [PATCH net 5/5] net: txgbe: fix to control VLAN strip Jiawen Wu
2024-04-18 19:54 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='046501da961c$77f3fba0$67dbf2e0$@trustnetic.com' \
--to=jiawenwu@trustnetic.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=duanqiangwen@net-swift.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).