From: Eric Dumazet <eric.dumazet@gmail.com>
To: Yafang Shao <laoar.shao@gmail.com>,
davem@davemloft.net, edumazet@google.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] tcp: add SNMP counter for the number of packets pruned from ofo queue
Date: Wed, 25 Jul 2018 06:33:41 -0700 [thread overview]
Message-ID: <047bc12f-9eb5-e512-10c5-6334c494c77e@gmail.com> (raw)
In-Reply-To: <1532524010-11855-1-git-send-email-laoar.shao@gmail.com>
On 07/25/2018 06:06 AM, Yafang Shao wrote:
> LINUX_MIB_OFOPRUNED is used to count how many times ofo queue is pruned,
> but sometimes we want to know how many packets are pruned from this queue,
> that could help us to track the dropped packets.
>
> As LINUX_MIB_OFOPRUNED is a useful event for us, so I introduce a new
> SNMP counter LINUX_MIB_OFOPRUNEDROP, which could be showed in netstat as
> OfoPruneDrop.
Okay, but why tracking number of skbs that are removed ?
Skb can contain many segments (because of GRO and TCP coalescing)
So your claim of tracking dropped packets is ill defined.
Also I prefer having net tree being merged into net-next, since your patch would
add a merge conflict.
next prev parent reply other threads:[~2018-07-25 13:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 13:06 [PATCH net-next] tcp: add SNMP counter for the number of packets pruned from ofo queue Yafang Shao
2018-07-25 13:33 ` Eric Dumazet [this message]
2018-07-25 13:40 ` Yafang Shao
2018-07-25 13:55 ` Eric Dumazet
2018-07-25 13:59 ` Yafang Shao
2018-07-26 1:42 ` Yafang Shao
2018-07-26 4:06 ` Eric Dumazet
2018-07-26 4:31 ` Yafang Shao
2018-07-26 4:36 ` Eric Dumazet
2018-07-26 4:42 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=047bc12f-9eb5-e512-10c5-6334c494c77e@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=laoar.shao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).