From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net-next] tcp: add SNMP counter for the number of packets pruned from ofo queue Date: Wed, 25 Jul 2018 06:33:41 -0700 Message-ID: <047bc12f-9eb5-e512-10c5-6334c494c77e@gmail.com> References: <1532524010-11855-1-git-send-email-laoar.shao@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Yafang Shao , davem@davemloft.net, edumazet@google.com Return-path: In-Reply-To: <1532524010-11855-1-git-send-email-laoar.shao@gmail.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 07/25/2018 06:06 AM, Yafang Shao wrote: > LINUX_MIB_OFOPRUNED is used to count how many times ofo queue is pruned, > but sometimes we want to know how many packets are pruned from this queue, > that could help us to track the dropped packets. > > As LINUX_MIB_OFOPRUNED is a useful event for us, so I introduce a new > SNMP counter LINUX_MIB_OFOPRUNEDROP, which could be showed in netstat as > OfoPruneDrop. Okay, but why tracking number of skbs that are removed ? Skb can contain many segments (because of GRO and TCP coalescing) So your claim of tracking dropped packets is ill defined. Also I prefer having net tree being merged into net-next, since your patch would add a merge conflict.