From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiner Kallweit Subject: Re: [PATCH net-next] net: phy: add GBit master / slave error detection Date: Thu, 19 Jul 2018 23:11:53 +0200 Message-ID: <048869a5-7fbe-f68d-8d9c-123b2ac38bd5@gmail.com> References: <60685308-a848-e4d0-e170-f2738f046679@gmail.com> <8ccaeb57-3150-65ce-2310-3aac52f446c5@gmail.com> <20180719144637.GA9119@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Florian Fainelli , David Miller , "netdev@vger.kernel.org" To: Andrew Lunn Return-path: Received: from mail-wr1-f68.google.com ([209.85.221.68]:39099 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730057AbeGSV4y (ORCPT ); Thu, 19 Jul 2018 17:56:54 -0400 Received: by mail-wr1-f68.google.com with SMTP id h10-v6so9360071wre.6 for ; Thu, 19 Jul 2018 14:11:59 -0700 (PDT) In-Reply-To: <20180719144637.GA9119@lunn.ch> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 19.07.2018 16:46, Andrew Lunn wrote: >>> AFAIR there was a patch a while ago from Mellanox guys that was possibly >>> extending the link notification with an error cause, this sounds like >>> something that could be useful to report to user space somehow to help >>> troubleshoot link down events. >>> >> Do you by chance have a reference to this patch? There's heavy development >> on the Mellanox drivers with a lot of patches. > > Hi Heiner, Florian > > A general mechanism has been added to allow error messages to be > reported via netlink sockets. I think wifi was the first to actually > make use of it, since i think Johannes Berg did the core work, but > other parts of the stack have also started using it. > I think you mean the devlink interface. With regard to nl80211 I'm aware that it's used for communication between Wifi core and userspace tools / daemons like hostapd and wpa_supplicant. The devlink use case reminds me of swconfig for switch port configuration under OpenWRT. For our use case I think this is overkill, and I wonder what the userspace tool would be that consumes our link down error info. Heiner > Just picking a commit at random, maybe not the best of examples: > > Fixes: 768075ebc238 ("nl80211: add a few extended error strings to key parsing") > > Andrew >