From: "Yuriy N. Shkandybin" <jura@netams.com>
To: "Jarek Poplawski" <jarkao2@o2.pl>
Cc: <akpm@linux-foundation.org>, <netdev@vger.kernel.org>,
<paulus@samba.org>, <greearb@candelatech.com>,
<mostrows@speakeasy.net>, <davem@davemloft.net>
Subject: Re: [PATCH] vlan: lockdep subclass for ppp _xmit_lock Re: ppp_generic: fix lockdep warning
Date: Thu, 10 May 2007 10:03:23 +0400 [thread overview]
Message-ID: <049301c792c8$ecdf4c40$0202fea9@Jura> (raw)
In-Reply-To: 20070510053052.GA1611@ff.dom.local
Yes, there is no real lockup with pppoe
ll repeat my configuration:
vpn (pptp(mostly)+pppoe) concentrator
PPPoE provided through 802.1q
+OSPF (quagga)
Jura
----- Original Message -----
From: "Jarek Poplawski" <jarkao2@o2.pl>
To: "Yuriy N. Shkandybin" <jura@netams.com>
Cc: <akpm@linux-foundation.org>; <netdev@vger.kernel.org>;
<paulus@samba.org>; <greearb@candelatech.com>; <mostrows@speakeasy.net>;
<davem@davemloft.net>
Sent: Thursday, May 10, 2007 9:30 AM
Subject: Re: [PATCH] vlan: lockdep subclass for ppp _xmit_lock Re:
ppp_generic: fix lockdep warning
> On Thu, May 10, 2007 at 12:06:09AM +0400, Yuriy N. Shkandybin wrote:
>> After applying this patch i've got this:
>>
>> =======================================================
>> [ INFO: possible circular locking dependency detected ]
>> 2.6.21-gentoo #2
>> -------------------------------------------------------
>> ospfd/3984 is trying to acquire lock:
>> (&ppp->wlock){-...}, at: [<ffffffff803512a0>] ppp_xmit_process+0x20/0x4f0
>>
>> but task is already holding lock:
>> (&dev->_xmit_lock){-+..}, at: [<ffffffff8038d778>] __qdisc_run+0x88/0x1c3
>>
>> which lock already depends on the new lock.
>
> Thanks Yuriy!
>
> As a matter of fact I suspected there will be something more.
> Lockdep always stops working after the first warning, and you
> have some very interesting (entangled) configuration, so each
> fix could uncover new warnings.
>
> I need some time to figure out this one, so I'd try to use your
> help yet... I hope it's only about lockdep warnings and there
> are no real lockups.
>
> Best regards,
> Jarek P.
>
next prev parent reply other threads:[~2007-05-10 6:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-26 7:27 [patch 10/15] ppp_generic: fix lockdep warning akpm
2007-04-26 8:39 ` David Miller
2007-04-26 10:49 ` Jarek Poplawski
2007-05-09 9:35 ` [PATCH] vlan: lockdep subclass for ppp _xmit_lock " Jarek Poplawski
2007-05-09 9:32 ` David Miller
2007-05-09 13:13 ` [PATCH (take 2)] vlan: lockdep class " Jarek Poplawski
2007-05-09 20:06 ` [PATCH] vlan: lockdep subclass " Yuriy N. Shkandybin
2007-05-10 5:30 ` Jarek Poplawski
2007-05-10 6:03 ` Yuriy N. Shkandybin [this message]
2007-05-10 6:39 ` Jarek Poplawski
2007-05-11 7:00 ` [PATCH] ppp_generic: lockdep class " Jarek Poplawski
2007-04-26 10:04 ` [patch 10/15] " Paul Mackerras
2007-04-26 11:28 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='049301c792c8$ecdf4c40$0202fea9@Jura' \
--to=jura@netams.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=greearb@candelatech.com \
--cc=jarkao2@o2.pl \
--cc=mostrows@speakeasy.net \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).