public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@kernel.org>
To: Fernando Fernandez Mancera <fmancera@suse.de>, netdev@vger.kernel.org
Cc: rbm@suse.com, "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 04/10 net-next v2] ipv6: prepare headers for ipv6_stub removal
Date: Tue, 10 Mar 2026 10:50:41 -0600	[thread overview]
Message-ID: <04a9571f-55d7-466a-bfcc-161f8347ef92@kernel.org> (raw)
In-Reply-To: <20260310153506.5181-5-fmancera@suse.de>

On 3/10/26 9:34 AM, Fernando Fernandez Mancera wrote:
> diff --git a/include/net/ip6_fib.h b/include/net/ip6_fib.h
> index 39c98c3d8ac5..62a1e96bbdd4 100644
> --- a/include/net/ip6_fib.h
> +++ b/include/net/ip6_fib.h
> @@ -486,11 +486,29 @@ void rt6_get_prefsrc(const struct rt6_info *rt, struct in6_addr *addr)
>  	rcu_read_unlock();
>  }
>  
> +#if IS_ENABLED(CONFIG_IPV6)
>  int fib6_nh_init(struct net *net, struct fib6_nh *fib6_nh,
>  		 struct fib6_config *cfg, gfp_t gfp_flags,
>  		 struct netlink_ext_ack *extack);
>  void fib6_nh_release(struct fib6_nh *fib6_nh);
>  void fib6_nh_release_dsts(struct fib6_nh *fib6_nh);
> +#else
> +static inline int fib6_nh_init(struct net *net, struct fib6_nh *fib6_nh,
> +			       struct fib6_config *cfg, gfp_t gfp_flags,
> +			       struct netlink_ext_ack *extack)
> +{

NL_SET_ERR_MSG(extack, "IPv6 support not enabled in kernel");

let's keep the helpful, user facing message

> +	return -EAFNOSUPPORT;
> +}
> +
> +static inline void fib6_nh_release(struct fib6_nh *fib6_nh)
> +{
> +}
> +
> +static inline void fib6_nh_release_dsts(struct fib6_nh *fib6_nh)
> +{
> +}
> +#endif
> +
>  
>  int call_fib6_entry_notifiers(struct net *net,
>  			      enum fib_event_type event_type,


  reply	other threads:[~2026-03-10 16:50 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-10 15:34 [PATCH 00/10 net-next v2] Convert CONFIG_IPV6 to built-in and remove stubs Fernando Fernandez Mancera
2026-03-10 15:34 ` [PATCH 01/10 net-next v2] ipv6: convert CONFIG_IPV6 to built-in only and clean up Kconfigs Fernando Fernandez Mancera
2026-03-12  3:02   ` Jakub Kicinski
2026-03-12 15:12     ` Fernando Fernandez Mancera
2026-03-12 16:05       ` Geert Uytterhoeven
2026-03-12  7:43   ` Geert Uytterhoeven
2026-03-16 15:44   ` Krzysztof Kozlowski
2026-03-10 15:34 ` [PATCH 02/10 net-next v2] ipv6: replace IS_BUILTIN(CONFIG_IPV6) with IS_ENABLED(CONFIG_IPV6) Fernando Fernandez Mancera
2026-03-10 15:34 ` [PATCH 03/10 net-next v2] ipv6: remove dynamic ICMPv6 sender registration infrastructure Fernando Fernandez Mancera
2026-03-10 15:34 ` [PATCH 04/10 net-next v2] ipv6: prepare headers for ipv6_stub removal Fernando Fernandez Mancera
2026-03-10 16:50   ` David Ahern [this message]
2026-03-10 15:34 ` [PATCH 05/10 net-next v2] drivers: net: drop ipv6_stub usage and use direct function calls Fernando Fernandez Mancera
2026-03-12 13:48   ` Jason A. Donenfeld
2026-03-13 10:54   ` Antonio Quartulli
2026-03-13 12:07   ` Edward Cree
2026-03-10 15:34 ` [PATCH 06/10 net-next v2] ipv4: " Fernando Fernandez Mancera
2026-03-10 15:34 ` [PATCH 07/10 net-next v2] net: convert remaining ipv6_stub users to " Fernando Fernandez Mancera
2026-03-10 15:34 ` [PATCH 08/10 net-next v2] bpf: remove ipv6_bpf_stub completely and use " Fernando Fernandez Mancera
2026-03-12 10:12   ` Daniel Borkmann
2026-03-10 15:34 ` [PATCH 09/10 net-next v2] ipv6: remove ipv6_stub infrastructure completely Fernando Fernandez Mancera
2026-03-10 15:34 ` [PATCH 10/10 net-next v2] netfilter: remove nf_ipv6_ops and use direct function calls Fernando Fernandez Mancera
2026-03-10 18:08 ` [PATCH 00/10 net-next v2] Convert CONFIG_IPV6 to built-in and remove stubs Ricardo B. Marlière
2026-03-12  3:01 ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=04a9571f-55d7-466a-bfcc-161f8347ef92@kernel.org \
    --to=dsahern@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fmancera@suse.de \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rbm@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox