From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07908C282CD for ; Mon, 28 Jan 2019 16:53:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C97082173C for ; Mon, 28 Jan 2019 16:53:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O6tM76Dj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388750AbfA1QxS (ORCPT ); Mon, 28 Jan 2019 11:53:18 -0500 Received: from mail-pg1-f177.google.com ([209.85.215.177]:36168 "EHLO mail-pg1-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388501AbfA1QxR (ORCPT ); Mon, 28 Jan 2019 11:53:17 -0500 Received: by mail-pg1-f177.google.com with SMTP id n2so7460370pgm.3 for ; Mon, 28 Jan 2019 08:53:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=bqSbxQtugDelHZRGfIgrdanIUKEGvMUeC8B3wjg7GJ4=; b=O6tM76DjNASYF8jpBxjbVdUZI/TXSzpcyZaQ/iwdFZSKMnJ6LKxvLc8e7I8IYFdtfb ZJkKpwBg29UkIhMuxFEREIEU7rqNdCv5IBxyW6B8TclMx/M6pgdif7M5QyaMKa43yuvs mGPp3qYsxbzb1o6n+W3jXV5lL+/q9w1AY0kOoIxIo8GFoL9S9uLFOmf5dd6HyqMLDzo+ lLAXIMmKbnsMLAZNaV8qEmGzj+bFu98aI8Fk/JercyaLL5ZrYUfLR0PBzAdjC+gzbeZ8 ky+cznv9xv7O5SFIwzvGcwk7/kR+QKS4PoJYfvWTcMiLPZxiYWDNK/Wd8UAidT4i9DlL ydww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bqSbxQtugDelHZRGfIgrdanIUKEGvMUeC8B3wjg7GJ4=; b=U4eoUEok64BmFA2wo6mEfY4Z4M3vJWVk6tv8OFtPiXi1H2JEZNvyoMoK6j9ReM1B3c WgBEFAGjY2ejXtMEfvrL8qoRGhqmmNi9njURwJidyFWxlfuxzxnm9cOxw0ztUL+3hSxR Hwvo2KZKaAmmLQyuoj9LwwLnsx7iiejOukJA1Pp43YECUzlCMmUmnj/0He3gL3VcyTFv JImhEZYsPvvw5A/TcLtGJdjarh19qnyDnFESxFPDbgLX1NSVmZeby500f7Ao7jHBLzpi BOHFgSBEw5nML49RmOdA4H1BfJvOOwxd2WQOH9okCn7XjbIksDRnadBGgVLyaiu8UF0G uoCQ== X-Gm-Message-State: AJcUukeL5MMPniWTueCRV/z4CEyckEchnzIME+iXlgynxWhH1US3Ho5g wu5UMhlcUnXQB98+5cyHu4uQt/27 X-Google-Smtp-Source: ALg8bN4pfzgmuyCS422YY/JvcGAJcnK2QXg/MRfmUejbOzxk76NjTVGojs39ch2fci7hH6WjN6PLeA== X-Received: by 2002:a63:cc12:: with SMTP id x18mr20395060pgf.33.1548694396187; Mon, 28 Jan 2019 08:53:16 -0800 (PST) Received: from ?IPv6:2601:282:800:fd80:6cf4:7f15:5073:c792? ([2601:282:800:fd80:6cf4:7f15:5073:c792]) by smtp.googlemail.com with ESMTPSA id u69sm67400747pfj.116.2019.01.28.08.53.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Jan 2019 08:53:15 -0800 (PST) Subject: Re: [PATCH iproute2-next 1/2] tc: replace print_string with fprintf for error messages To: Stephen Hemminger , netdev@vger.kernel.org References: <20190124203014.7450-1-stephen@networkplumber.org> From: David Ahern Message-ID: <04bcacca-9a7a-a812-24a6-70f6203d5b83@gmail.com> Date: Mon, 28 Jan 2019 09:53:14 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190124203014.7450-1-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/24/19 1:30 PM, Stephen Hemminger wrote: > diff --git a/tc/m_connmark.c b/tc/m_connmark.c > index 45e2d05f1a91..34d80b1a27c0 100644 > --- a/tc/m_connmark.c > +++ b/tc/m_connmark.c > @@ -114,7 +114,7 @@ static int print_connmark(struct action_util *au, FILE *f, struct rtattr *arg) > > parse_rtattr_nested(tb, TCA_CONNMARK_MAX, arg); > if (tb[TCA_CONNMARK_PARMS] == NULL) { > - print_string(PRINT_FP, NULL, "%s", "[NULL connmark parameters]"); > + fprintf(stderr, "NULL connmark parameters\n"); > return -1; > } > > diff --git a/tc/m_csum.c b/tc/m_csum.c > index 752269d1d020..450f2b557b44 100644 > --- a/tc/m_csum.c > +++ b/tc/m_csum.c > @@ -172,7 +172,7 @@ print_csum(struct action_util *au, FILE *f, struct rtattr *arg) > parse_rtattr_nested(tb, TCA_CSUM_MAX, arg); > > if (tb[TCA_CSUM_PARMS] == NULL) { > - fprintf(f, "[NULL csum parameters]"); > + fprintf(stderr, "missing csum parameters\n"); > return -1; > } > sel = RTA_DATA(tb[TCA_CSUM_PARMS]); > diff --git a/tc/m_gact.c b/tc/m_gact.c > index a0a3c33d23da..342927bc2ed7 100644 > --- a/tc/m_gact.c > +++ b/tc/m_gact.c > @@ -174,7 +174,7 @@ print_gact(struct action_util *au, FILE *f, struct rtattr *arg) > parse_rtattr_nested(tb, TCA_GACT_MAX, arg); > > if (tb[TCA_GACT_PARMS] == NULL) { > - print_string(PRINT_FP, NULL, "%s", "[NULL gact parameters]"); > + fprintf(stderr, "[NULL gact parameters]\n"); We should be consistent and not showing the the '[]'. You have several error messages with those included.