From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
davem@davemloft.net, kuba@kernel.org
Cc: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] net: renesas: ravb: Fix a stuck issue when a lot of frames are received
Date: Sun, 9 May 2021 13:21:35 +0300 [thread overview]
Message-ID: <04c93015-5fe2-8471-3da5-ee85585d9e6c@gmail.com> (raw)
In-Reply-To: <68291557-0af5-de1e-4f4f-b104bb65c6b3@gmail.com>
On 08.05.2021 23:47, Sergei Shtylyov wrote:
> Posting a review of the already commited (over my head) patch. It would have
> been appropriate if the patch looked OK but it's not. :-/
>
>> When a lot of frames were received in the short term, the driver
>> caused a stuck of receiving until a new frame was received. For example,
>> the following command from other device could cause this issue.
>>
>> $ sudo ping -f -l 1000 -c 1000 <this driver's ipaddress>
>
> -l is essential here, right?
> Have you tried testing sh_eth sriver like that, BTW?
It's driver! :-)
>> The previous code always cleared the interrupt flag of RX but checks
>> the interrupt flags in ravb_poll(). So, ravb_poll() could not call
>> ravb_rx() in the next time until a new RX frame was received if
>> ravb_rx() returned true. To fix the issue, always calls ravb_rx()
>> regardless the interrupt flags condition.
>
> That bacially defeats the purpose of IIUC...
^ NAPI,
I was sure I typed NAPI here, yet it got lost in the edits. :-)
>> Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")
>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
[...]
MBR, Sergei
next prev parent reply other threads:[~2021-05-09 10:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 4:52 [PATCH] net: renesas: ravb: Fix a stuck issue when a lot of frames are received Yoshihiro Shimoda
2021-04-21 18:00 ` patchwork-bot+netdevbpf
2021-04-21 18:14 ` Sergei Shtylyov
2021-04-21 18:20 ` David Miller
2021-05-05 19:00 ` Sergei Shtylyov
2021-05-05 20:09 ` Sergei Shtylyov
2021-05-08 20:47 ` Sergei Shtylyov
2021-05-09 10:21 ` Sergei Shtylyov [this message]
2021-05-10 10:29 ` Yoshihiro Shimoda
2021-05-17 8:23 ` Yoshihiro Shimoda
2021-05-17 19:35 ` Sergei Shtylyov
2021-05-18 2:20 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04c93015-5fe2-8471-3da5-ee85585d9e6c@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).