Re: r8169: transmit transmit queue timed out - v6.4 cycle

[Heiner Kallweit <hkallweit1@gmail.com>]

On 13.07.2023 09:01, Kurt Kanzenbach wrote:
> Hello Heiner,
> 
> On Mon Jul 10 2023, Heiner Kallweit wrote:
>> On 05.07.2023 00:25, Tobias Klausmann wrote:
>>> Hi, top posting as well, as im on vacation, too. The system does not
>>> allow disabling ASPM, it is a very constrained notebook BIOS, thus
>>> the suggestion is nit feasible. All in all the sugesstion seems not
>>> favorable for me, as it is unknown how many systems are broken the
>>> same way. Having a workaround adviced as default seems oretty wrong
>>> to me.
>>>
>>
>> To get a better understanding of the affected system:
>> Could you please provide a full dmesg log and the lspci -vv output?
> 
> I'm having the same problem as described by Tobias on a desktop
> machine. v6.3 works; v6.4 results in transmit queue timeouts
> occasionally. Reverting 2ab19de62d67 ("r8169: remove ASPM restrictions
> now that ASPM is disabled during NAPI poll") "solves" the issue.
> 
> From dmesg:
> 
> |~ % dmesg | grep -i ASPM
> |[    0.152746] ACPI FADT declares the system doesn't support PCIe ASPM, so disable it
> |[    0.905100] acpi PNP0A08:00: _OSC: OS supports [ExtendedConfig ASPM ClockPM Segments MSI HPX-Type3]
> |[    0.906508] acpi PNP0A08:00: FADT indicates ASPM is unsupported, using BIOS configuration
> |[    1.156585] pci 10000:e1:00.0: can't override BIOS ASPM; OS doesn't have ASPM control
> |[    1.300059] r8169 0000:03:00.0: can't disable ASPM; OS doesn't have ASPM control
> 
> In addition, with commit 2ab19de62d67 in kernel regular messages like
> this show up:
> 
> |[ 7487.214593] pcieport 0000:00:1c.2: AER: Corrected error received: 0000:03:00.0
> 
> I'm happy to test any patches or provide more info if needed.
> 
Thanks for the report. It's interesting that the issue seems to occur only on systems
where BIOS doesn't allow OS to control ASPM. Maybe this results in the PCI subsystem
not properly initializing something.
Kurt/Klaus: Could you please boot with cmd line parameter pcie_aspm=force and see
whether this changes something?
This parameter lets Linux ignore the BIOS setting. You should see a message
"PCIe ASPM is forcibly enabled" in the dmesg log with this parameter.

> Thanks,
> Kurt

Heiner