From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Samudrala, Sridhar" Subject: Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available Date: Fri, 2 Mar 2018 11:52:27 -0800 Message-ID: <04e6981c-bb8d-0af9-5fe3-b9a7f7def3f5@intel.com> References: <1519934923-39372-1-git-send-email-sridhar.samudrala@intel.com> <1519934923-39372-3-git-send-email-sridhar.samudrala@intel.com> <20180302083605.GD2099@nanopsycho> <20180302213920-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Jiri Pirko , Stephen Hemminger , David Miller , Netdev , virtio-dev@lists.oasis-open.org, "Brandeburg, Jesse" , "Duyck, Alexander H" , Jakub Kicinski To: "Michael S. Tsirkin" , Alexander Duyck Return-path: Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: In-Reply-To: <20180302213920-mutt-send-email-mst@kernel.org> Content-Language: en-US List-Id: netdev.vger.kernel.org On 3/2/2018 11:41 AM, Michael S. Tsirkin wrote: > On Fri, Mar 02, 2018 at 07:26:25AM -0800, Alexander Duyck wrote: >> The design limits things to a 1:1 relationship since we just have the >> child and backup pointers, but I don't think I am seeing exception >> handling to prevent us from overwriting the child pointers so there >> may be a leak there. >> >> Thanks. >> >> - Alex > In fact maintaining a list in that case would be nicer, and > just use an arbitrary one. > E.g. one can see how a user wanting to swap device 1 for device 2 > might first add device 2 with same MAC then drop device 1. It should be possible to swap VF1 with VF2 by - enabling virtio link - unplugging VF1 - plugging VF2 - disabling virtio link