netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Vladimir Oltean <olteanv@gmail.com>,
	vivien.didelot@gmail.com, andrew@lunn.ch, davem@davemloft.net,
	vinicius.gomes@intel.com, vedang.patel@intel.com,
	richardcochran@gmail.com
Cc: weifeng.voon@intel.com, jiri@mellanox.com, m-karicheri2@ti.com,
	jose.abreu@synopsys.com, ilias.apalodimas@linaro.org,
	jhs@mojatatu.com, xiyou.wangcong@gmail.com,
	kurt.kanzenbach@linutronix.de, joergen.andreasen@microchip.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH v4 net-next 4/6] net: dsa: sja1105: Advertise the 8 TX queues
Date: Sun, 15 Sep 2019 08:15:12 -0700	[thread overview]
Message-ID: <05136e2f-b56d-03a1-e1de-e27bc4472048@gmail.com> (raw)
In-Reply-To: <20190915020003.27926-5-olteanv@gmail.com>



On 9/14/2019 7:00 PM, Vladimir Oltean wrote:
> This is a preparation patch for the tc-taprio offload (and potentially
> for other future offloads such as tc-mqprio).
> 
> Instead of looking directly at skb->priority during xmit, let's get the
> netdev queue and the queue-to-traffic-class mapping, and put the
> resulting traffic class into the dsa_8021q PCP field. The switch is
> configured with a 1-to-1 PCP-to-ingress-queue-to-egress-queue mapping
> (see vlan_pmap in sja1105_main.c), so the effect is that we can inject
> into a front-panel's egress traffic class through VLAN tagging from
> Linux, completely transparently.
> 
> Unfortunately the switch doesn't look at the VLAN PCP in the case of
> management traffic to/from the CPU (link-local frames at
> 01-80-C2-xx-xx-xx or 01-1B-19-xx-xx-xx) so we can't alter the
> transmission queue of this type of traffic on a frame-by-frame basis. It
> is only selected through the "hostprio" setting which ATM is harcoded in
> the driver to 7.
> 
> Signed-off-by: Vladimir Oltean <olteanv@gmail.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

  reply	other threads:[~2019-09-15 15:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-15  1:59 [PATCH v4 net-next 0/6] tc-taprio offload for SJA1105 DSA Vladimir Oltean
2019-09-15  1:59 ` [PATCH v4 net-next 1/6] taprio: Add support for hardware offloading Vladimir Oltean
2019-09-15  1:59 ` [PATCH v4 net-next 2/6] net: dsa: Pass ndo_setup_tc slave callback to drivers Vladimir Oltean
2019-09-16  9:56   ` Ilias Apalodimas
2019-09-15  2:00 ` [PATCH v4 net-next 3/6] net: dsa: sja1105: Add static config tables for scheduling Vladimir Oltean
2019-09-15  2:00 ` [PATCH v4 net-next 4/6] net: dsa: sja1105: Advertise the 8 TX queues Vladimir Oltean
2019-09-15 15:15   ` Florian Fainelli [this message]
2019-09-15 16:41   ` Jose Abreu
2019-09-15 17:28     ` Vladimir Oltean
2019-09-15  2:00 ` [PATCH v4 net-next 5/6] net: dsa: sja1105: Configure the Time-Aware Scheduler via tc-taprio offload Vladimir Oltean
2019-09-15  2:00 ` [PATCH v4 net-next 6/6] docs: net: dsa: sja1105: Add info about the Time-Aware Scheduler Vladimir Oltean
2019-09-16 19:36 ` [PATCH v4 net-next 0/6] tc-taprio offload for SJA1105 DSA David Miller
2019-09-16 19:52   ` Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05136e2f-b56d-03a1-e1de-e27bc4472048@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jhs@mojatatu.com \
    --cc=jiri@mellanox.com \
    --cc=joergen.andreasen@microchip.com \
    --cc=jose.abreu@synopsys.com \
    --cc=kurt.kanzenbach@linutronix.de \
    --cc=m-karicheri2@ti.com \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=richardcochran@gmail.com \
    --cc=vedang.patel@intel.com \
    --cc=vinicius.gomes@intel.com \
    --cc=vivien.didelot@gmail.com \
    --cc=weifeng.voon@intel.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).