Re: [PATCH net-next v2 3/7] amd-xgbe: convert to ndo_hwtstamp callbacks

[Jacob Keller <jacob.e.keller@intel.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1537 bytes --]



On 10/14/2025 3:42 PM, Vadim Fedorenko wrote:
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-hwtstamp.c b/drivers/net/ethernet/amd/xgbe/xgbe-hwtstamp.c
> index bc52e5ec6420..0127988e10be 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-hwtstamp.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-hwtstamp.c
> @@ -157,26 +157,24 @@ void xgbe_tx_tstamp(struct work_struct *work)
>  	spin_unlock_irqrestore(&pdata->tstamp_lock, flags);
>  }
>  
> -int xgbe_get_hwtstamp_settings(struct xgbe_prv_data *pdata, struct ifreq *ifreq)
> +int xgbe_get_hwtstamp_settings(struct net_device *netdev,
> +			       struct kernel_hwtstamp_config *config)
>  {
> -	if (copy_to_user(ifreq->ifr_data, &pdata->tstamp_config,
> -			 sizeof(pdata->tstamp_config)))
> -		return -EFAULT;
> +	struct xgbe_prv_data *pdata = netdev_priv(netdev);
> +
> +	*config = pdata->tstamp_config;
>  
>  	return 0;
>  }
>  
> -int xgbe_set_hwtstamp_settings(struct xgbe_prv_data *pdata, struct ifreq *ifreq)
> +int xgbe_set_hwtstamp_settings(struct net_device *netdev,
> +			       struct kernel_hwtstamp_config *config,
> +			       struct netlink_ext_ack *extack)
>  {
> -	struct hwtstamp_config config;
> -	unsigned int mac_tscr;
> -
> -	if (copy_from_user(&config, ifreq->ifr_data, sizeof(config)))
> -		return -EFAULT;
> -
> -	mac_tscr = 0;
> +	struct xgbe_prv_data *pdata = netdev_priv(netdev);
> +	unsigned int mac_tscr = 0;
>  

I noticed in this driver you didn't bother to add NL_SET_ERR_MSG calls.
Any particular reason?

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]