From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mail-lf0-f42.google.com ([209.85.215.42]:40043 "EHLO
        mail-lf0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751837AbeCXJwU (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sat, 24 Mar 2018 05:52:20 -0400
Received: by mail-lf0-f42.google.com with SMTP id e5-v6so21666967lfb.7
        for <netdev@vger.kernel.org>; Sat, 24 Mar 2018 02:52:19 -0700 (PDT)
Subject: Re: [net 7/8] net/mlx5e: Avoid using the ipv6 stub in the TC offload
 neigh update path
To: Saeed Mahameed <saeedm@mellanox.com>,
        "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Or Gerlitz <ogerlitz@mellanox.com>
References: <20180323220534.19353-1-saeedm@mellanox.com>
 <20180323220534.19353-8-saeedm@mellanox.com>
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Message-ID: <053eef8f-a218-27d2-df75-e49289a4c3d3@cogentembedded.com>
Date: Sat, 24 Mar 2018 12:52:18 +0300
MIME-Version: 1.0
In-Reply-To: <20180323220534.19353-8-saeedm@mellanox.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Hello!

On 3/24/2018 1:05 AM, Saeed Mahameed wrote:

> From: Or Gerlitz <ogerlitz@mellanox.com>
> 
> Currently we use the global ipv6_stub var to access the ipv6 global
> nd table. This practice gets us to troubles when the stub is only partially
> set e.g when ipv6 is loaded under the disabled policy. In this case, as of commit
> 343d60aada5a "ipv6: change ipv6_stub_impl.ipv6_dst_lookup to take net argument"

    The summary line must be enclosed in (""), not just "".

> the stub is not null, but stub->nd_tbl is and we crash.
> 
> As we can access directly the ipv6 nd_tbl, the fix is just avoid the

As we can access the ipv6 nd_tbl directly, the fix is just to avoid the

> reference through the stub. There is one place in the code were we
                                                              ^^^^
     Where?

> issue ipv6 route lookup and keep doing it through the stub, but that
> mentioned commit makes sure we get -EAFNOSUPPORT from the stack.
> 
> Fixes: 232c001398ae ('net/mlx5e: Add support to neighbour update flow')

    ("") here as well.

> Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
> Reviewed-by: Aviv Heller <avivh@mellanox.com>
> Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
[...]

MBR, Sergei