From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19F14C7618F for ; Fri, 26 Jul 2019 22:19:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EC9A022BF5 for ; Fri, 26 Jul 2019 22:19:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728522AbfGZWTE (ORCPT ); Fri, 26 Jul 2019 18:19:04 -0400 Received: from smtprelay0089.hostedemail.com ([216.40.44.89]:54963 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726651AbfGZWTD (ORCPT ); Fri, 26 Jul 2019 18:19:03 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 3D0EC182251B2; Fri, 26 Jul 2019 22:19:02 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: pail14_4e54f40abf635 X-Filterd-Recvd-Size: 2393 Received: from XPS-9350.home (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf07.hostedemail.com (Postfix) with ESMTPA; Fri, 26 Jul 2019 22:18:58 +0000 (UTC) Message-ID: <05602c954c689ffcd796e9468c52bca6fa4efe3f.camel@perches.com> Subject: Re: [PATCH V2 net-next 07/11] net: hns3: adds debug messages to identify eth down cause From: Joe Perches To: Saeed Mahameed , "tanhuazhong@huawei.com" , "davem@davemloft.net" Cc: "lipeng321@huawei.com" , "yisen.zhuang@huawei.com" , "salil.mehta@huawei.com" , "linuxarm@huawei.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "liuyonglong@huawei.com" Date: Fri, 26 Jul 2019 15:18:57 -0700 In-Reply-To: References: <1564111502-15504-1-git-send-email-tanhuazhong@huawei.com> <1564111502-15504-8-git-send-email-tanhuazhong@huawei.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.5-0ubuntu0.18.10.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 2019-07-26 at 22:00 +0000, Saeed Mahameed wrote: > On Fri, 2019-07-26 at 11:24 +0800, Huazhong Tan wrote: > > From: Yonglong Liu > > > > Some times just see the eth interface have been down/up via > > dmesg, but can not know why the eth down. So adds some debug > > messages to identify the cause for this. [] > > diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c > [] > > @@ -459,6 +459,10 @@ static int hns3_nic_net_open(struct net_device > > *netdev) > > h->ae_algo->ops->set_timer_task(priv->ae_handle, true); > > > > hns3_config_xps(priv); > > + > > + if (netif_msg_drv(h)) > > + netdev_info(netdev, "net open\n"); > > + > > to make sure this is only intended for debug, and to avoid repetition. > #define hns3_dbg(__dev, format, args...) \ > ({ \ > if (netif_msg_drv(h)) \ > netdev_info(h->netdev, format, ##args); \ > }) netif_dbg(h, drv, h->netdev, "net open\n")