From: Jamal Hadi Salim <jhs@mojatatu.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, lorenzo@google.com, mrv@mojatatu.com,
hadi@mojatatu.com
Subject: Re: [PATCH net-next 1/1] net: reflect mark on tcp syn ack packets
Date: Sun, 11 Jun 2017 07:58:18 -0400 [thread overview]
Message-ID: <056cbd5c-2a5f-8767-e584-591f39bc2029@mojatatu.com> (raw)
In-Reply-To: <20170610.190213.1437094451353913622.davem@davemloft.net>
On 17-06-10 07:02 PM, David Miller wrote:
>> @@ -173,7 +173,8 @@ int ip_build_and_send_pkt(struct sk_buff *skb, const struct sock *sk,
>> }
>>
>> skb->priority = sk->sk_priority;
>> - skb->mark = sk->sk_mark;
>> + if (!skb->mark)
>> + skb->mark = sk->sk_mark;
>
> Maybe this should both be "inet_request_mark()"?
>
Challenge is making of a synack requires a new allocated skb;
and sk is a listening socket - which should/has a mark of
0 meaning at ip_build_and_send_pkt() it overrides
the value already set on the skb->mark.
cheers,
jamal
> Also, Lorenzo, please review.
>
next prev parent reply other threads:[~2017-06-11 11:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-10 13:31 [PATCH net-next 1/1] net: reflect mark on tcp syn ack packets Jamal Hadi Salim
2017-06-10 23:02 ` David Miller
2017-06-11 11:58 ` Jamal Hadi Salim [this message]
2017-06-13 0:34 ` Lorenzo Colitti
2017-06-13 11:33 ` Jamal Hadi Salim
2017-06-13 13:58 ` Lorenzo Colitti
2017-06-18 12:45 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=056cbd5c-2a5f-8767-e584-591f39bc2029@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=davem@davemloft.net \
--cc=hadi@mojatatu.com \
--cc=lorenzo@google.com \
--cc=mrv@mojatatu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox