From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Michael Thalmeier <michael.thalmeier@hale.at>,
Deepak Sharma <deepak.sharma.472935@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Simon Horman <horms@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Michael Thalmeier <michael@thalmeier.at>,
stable@vger.kernel.org
Subject: Re: [PATCH net v3] net: nfc: nci: Fix parameter validation for packet data
Date: Mon, 22 Dec 2025 15:21:59 +0000 [thread overview]
Message-ID: <059d9fbb-7383-441c-9368-1c96eafae1f8@linux.dev> (raw)
In-Reply-To: <20251222143143.256980-1-michael.thalmeier@hale.at>
On 22/12/2025 14:31, Michael Thalmeier wrote:
> @@ -668,6 +679,11 @@ static int nci_rf_intf_activated_ntf_packet(struct nci_dev *ndev,
> }
> }
>
> + if (skb->len < (data - skb->data) + sizeof(ntf.data_exch_rf_tech_and_mode) +
> + sizeof(ntf.data_exch_tx_bit_rate) + sizeof (ntf.data_exch_rx_bit_rate) +
extra space between sizeof and the bracket
> + sizeof(ntf.activation_params_len))
> + return -EINVAL;
> +
> ntf.data_exch_rf_tech_and_mode = *data++;
> ntf.data_exch_tx_bit_rate = *data++;
> ntf.data_exch_rx_bit_rate = *data++;
prev parent reply other threads:[~2025-12-22 15:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-22 14:31 [PATCH net v3] net: nfc: nci: Fix parameter validation for packet data Michael Thalmeier
2025-12-22 15:21 ` Vadim Fedorenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=059d9fbb-7383-441c-9368-1c96eafae1f8@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=deepak.sharma.472935@gmail.com \
--cc=horms@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.thalmeier@hale.at \
--cc=michael@thalmeier.at \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).