From: shaozhengchao <shaozhengchao@huawei.com>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, vinicius.gomes@intel.com,
stephen@networkplumber.org, shuah@kernel.org,
victor@mojatatu.com
Cc: <zhijianx.li@intel.com>, <weiyongjun1@huawei.com>,
<yuehaibing@huawei.com>
Subject: Re: [PATCH net-next,v2 03/18] selftests/tc-testings: add selftests for cake qdisc
Date: Wed, 21 Sep 2022 10:08:42 +0800 [thread overview]
Message-ID: <05bf784d-e0aa-0dde-ca6b-e147b9753f20@huawei.com> (raw)
In-Reply-To: <87r106w3tm.fsf@toke.dk>
On 2022/9/20 21:52, Toke Høiland-Jørgensen wrote:
> Zhengchao Shao <shaozhengchao@huawei.com> writes:
>
>> Test 1212: Create CAKE with default setting
>> Test 3281: Create CAKE with bandwidth limit
>> Test c940: Create CAKE with autorate-ingress flag
>> Test 2310: Create CAKE with rtt time
>> Test 2385: Create CAKE with besteffort flag
>> Test a032: Create CAKE with diffserv8 flag
>> Test 2349: Create CAKE with diffserv4 flag
>> Test 8472: Create CAKE with flowblind flag
>> Test 2341: Create CAKE with dsthost and nat flag
>> Test 5134: Create CAKE with wash flag
>> Test 2302: Create CAKE with flowblind and no-split-gso flag
>> Test 0768: Create CAKE with dual-srchost and ack-filter flag
>> Test 0238: Create CAKE with dual-dsthost and ack-filter-aggressive flag
>> Test 6572: Create CAKE with memlimit and ptm flag
>> Test 2436: Create CAKE with fwmark and atm flag
>> Test 3984: Create CAKE with overhead and mpu
>> Test 5421: Create CAKE with conservative and ingress flag
>> Test 6854: Delete CAKE with conservative and ingress flag
>> Test 2342: Replace CAKE with mpu
>> Test 2313: Change CAKE with mpu
>> Test 4365: Show CAKE class
>>
>> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
>
> The subject prefix is misspelled for all the test patches (should be
> selftests/tc-testing without the last 's').
>
> Also, v2 of the series wasn't properly threaded for some reason, which
> makes it harder to apply as a whole.
>
> Other than those nits, for this patch:
>
> Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
>
Hi Toke：
Thank you for your review. I will send v3.
Zhengchao Shao
prev parent reply other threads:[~2022-09-21 2:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 5:03 [PATCH net-next,v2 03/18] selftests/tc-testings: add selftests for cake qdisc Zhengchao Shao
2022-09-20 13:52 ` Toke Høiland-Jørgensen
2022-09-21 2:08 ` shaozhengchao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05bf784d-e0aa-0dde-ca6b-e147b9753f20@huawei.com \
--to=shaozhengchao@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=stephen@networkplumber.org \
--cc=toke@redhat.com \
--cc=victor@mojatatu.com \
--cc=vinicius.gomes@intel.com \
--cc=weiyongjun1@huawei.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yuehaibing@huawei.com \
--cc=zhijianx.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).