Netdev List
 help / color / mirror / Atom feed
From: Edward Cree <ecree@solarflare.com>
To: <linux-net-drivers@solarflare.com>, <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>
Subject: [PATCH net-next 6/6] sfc: populate the timer reload field
Date: Mon, 18 Dec 2017 16:57:41 +0000	[thread overview]
Message-ID: <05f93b11-0eb3-d365-427c-ee118ef2db64@solarflare.com> (raw)
In-Reply-To: <f9e1279b-03d0-729c-2518-c1e204444447@solarflare.com>

From: Bert Kenward <bkenward@solarflare.com>

The timer mode register now has a separate field for the reload value.
Since we always use this timer with the reload (for interrupt moderation)
we set this to the same as the initial value.

Previous hardware ignores this field, so we can safely set these bits
on all hardware that uses this register.

Signed-off-by: Edward Cree <ecree@solarflare.com>
---
 drivers/net/ethernet/sfc/ef10.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c
index 56a6bc60dac1..1f64c7f60943 100644
--- a/drivers/net/ethernet/sfc/ef10.c
+++ b/drivers/net/ethernet/sfc/ef10.c
@@ -2010,8 +2010,9 @@ static void efx_ef10_push_irq_moderation(struct efx_channel *channel)
 	} else {
 		unsigned int ticks = efx_usecs_to_ticks(efx, usecs);
 
-		EFX_POPULATE_DWORD_2(timer_cmd, ERF_DZ_TC_TIMER_MODE, mode,
-				     ERF_DZ_TC_TIMER_VAL, ticks);
+		EFX_POPULATE_DWORD_3(timer_cmd, ERF_DZ_TC_TIMER_MODE, mode,
+				     ERF_DZ_TC_TIMER_VAL, ticks,
+				     ERF_FZ_TC_TMR_REL_VAL, ticks);
 		efx_writed_page(efx, &timer_cmd, ER_DZ_EVQ_TMR,
 				channel->channel);
 	}

  parent reply	other threads:[~2017-12-18 16:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-18 16:54 [PATCH net-next 0/6] sfc: Initial X2000-series (Medford2) support Edward Cree
2017-12-18 16:55 ` [PATCH net-next 1/6] sfc: make mem_bar a function rather than a constant Edward Cree
2017-12-18 16:56 ` [PATCH net-next 2/6] sfc: support VI strides other than 8k Edward Cree
2017-12-18 16:56 ` [PATCH net-next 3/6] sfc: add Medford2 (SFC9250) PCI Device IDs Edward Cree
2017-12-18 16:56 ` [PATCH net-next 4/6] sfc: improve PTP error reporting Edward Cree
2017-12-18 16:57 ` [PATCH net-next 5/6] sfc: update EF10 register definitions Edward Cree
2017-12-18 16:57 ` Edward Cree [this message]
2017-12-18 18:16 ` [PATCH net-next 0/6] sfc: Initial X2000-series (Medford2) support David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05f93b11-0eb3-d365-427c-ee118ef2db64@solarflare.com \
    --to=ecree@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=linux-net-drivers@solarflare.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox