[PATCH] vdpa: consume device_features parameter

[PATCH] vdpa: consume device_features parameter

[Shannon Nelson]

From: Allen Hubbe <allen.hubbe@amd.com>

Consume the parameter to device_features when parsing command line
options.  Otherwise the parameter may be used again as an option name.

 # vdpa dev add ... device_features 0xdeadbeef mac 00:11:22:33:44:55
 Unknown option "0xdeadbeef"

Fixes: a4442ce58ebb ("vdpa: allow provisioning device features")
Signed-off-by: Allen Hubbe <allen.hubbe@amd.com>
Reviewed-by: Shannon Nelson <shannon.nelson@amd.com>
---
 vdpa/vdpa.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/vdpa/vdpa.c b/vdpa/vdpa.c
index 27647d73d498..8a2fca8647b6 100644
--- a/vdpa/vdpa.c
+++ b/vdpa/vdpa.c
@@ -353,6 +353,8 @@ static int vdpa_argv_parse(struct vdpa *vdpa, int argc, char **argv,
 						&opts->device_features);
 			if (err)
 				return err;
+
+			NEXT_ARG_FWD();
 			o_found |= VDPA_OPT_VDEV_FEATURES;
 		} else {
 			fprintf(stderr, "Unknown option \"%s\"\n", *argv);
-- 
2.17.1

Re: [PATCH] vdpa: consume device_features parameter

[Jason Wang]

On Sat, May 13, 2023 at 12:42 AM Shannon Nelson <shannon.nelson@amd.com> wrote:
>
> From: Allen Hubbe <allen.hubbe@amd.com>
>
> Consume the parameter to device_features when parsing command line
> options.  Otherwise the parameter may be used again as an option name.
>
>  # vdpa dev add ... device_features 0xdeadbeef mac 00:11:22:33:44:55
>  Unknown option "0xdeadbeef"
>
> Fixes: a4442ce58ebb ("vdpa: allow provisioning device features")
> Signed-off-by: Allen Hubbe <allen.hubbe@amd.com>
> Reviewed-by: Shannon Nelson <shannon.nelson@amd.com>

Acked-by: Jason Wang <jasowang@redhat.com>

Thanks

> ---
>  vdpa/vdpa.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/vdpa/vdpa.c b/vdpa/vdpa.c
> index 27647d73d498..8a2fca8647b6 100644
> --- a/vdpa/vdpa.c
> +++ b/vdpa/vdpa.c
> @@ -353,6 +353,8 @@ static int vdpa_argv_parse(struct vdpa *vdpa, int argc, char **argv,
>                                                 &opts->device_features);
>                         if (err)
>                                 return err;
> +
> +                       NEXT_ARG_FWD();
>                         o_found |= VDPA_OPT_VDEV_FEATURES;
>                 } else {
>                         fprintf(stderr, "Unknown option \"%s\"\n", *argv);
> --
> 2.17.1
>

Re: [PATCH] vdpa: consume device_features parameter

[Eugenio Perez Martin]

On Fri, May 12, 2023 at 6:42 PM Shannon Nelson <shannon.nelson@amd.com> wrote:
>
> From: Allen Hubbe <allen.hubbe@amd.com>
>
> Consume the parameter to device_features when parsing command line
> options.  Otherwise the parameter may be used again as an option name.
>
>  # vdpa dev add ... device_features 0xdeadbeef mac 00:11:22:33:44:55
>  Unknown option "0xdeadbeef"
>
> Fixes: a4442ce58ebb ("vdpa: allow provisioning device features")
> Signed-off-by: Allen Hubbe <allen.hubbe@amd.com>
> Reviewed-by: Shannon Nelson <shannon.nelson@amd.com>

Acked-by: Eugenio Pérez <eperezma@redhat.com>


> ---
>  vdpa/vdpa.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/vdpa/vdpa.c b/vdpa/vdpa.c
> index 27647d73d498..8a2fca8647b6 100644
> --- a/vdpa/vdpa.c
> +++ b/vdpa/vdpa.c
> @@ -353,6 +353,8 @@ static int vdpa_argv_parse(struct vdpa *vdpa, int argc, char **argv,
>                                                 &opts->device_features);
>                         if (err)
>                                 return err;
> +
> +                       NEXT_ARG_FWD();
>                         o_found |= VDPA_OPT_VDEV_FEATURES;
>                 } else {
>                         fprintf(stderr, "Unknown option \"%s\"\n", *argv);
> --
> 2.17.1
>
>

Re: [PATCH] vdpa: consume device_features parameter

[Si-Wei Liu]

Hi David,

Why this patch doesn't get picked in the last 4 months? Maybe the 
subject is not clear, but this is an iproute2 patch. Would it be 
possible to merge at your earliest convenience?

PS, adding my R-b to the patch.

Thanks,
-Siwei


On Sat, May 13, 2023 at 12:42 AM Shannon Nelson <shannon.nelson@amd.com> 
wrote:
 >
 > From: Allen Hubbe <allen.hubbe@amd.com>
 >
 > Consume the parameter to device_features when parsing command line
 > options.  Otherwise the parameter may be used again as an option name.
 >
 >  # vdpa dev add ... device_features 0xdeadbeef mac 00:11:22:33:44:55
 >  Unknown option "0xdeadbeef"
 >
 > Fixes: a4442ce58ebb ("vdpa: allow provisioning device features")
 > Signed-off-by: Allen Hubbe <allen.hubbe@amd.com>
 > Reviewed-by: Shannon Nelson <shannon.nelson@amd.com>

Reviewed-by: Si-Wei Liu <si-wei.liu@oracle.com>

 > ---
 >  vdpa/vdpa.c | 2 ++
 >  1 file changed, 2 insertions(+)
 >
 > diff --git a/vdpa/vdpa.c b/vdpa/vdpa.c
 > index 27647d73d498..8a2fca8647b6 100644
 > --- a/vdpa/vdpa.c
 > +++ b/vdpa/vdpa.c
 > @@ -353,6 +353,8 @@ static int vdpa_argv_parse(struct vdpa *vdpa, int 
argc, char **argv,
 > &opts->device_features);
 >                         if (err)
 >                                 return err;
 > +
 > +                       NEXT_ARG_FWD();
 >                         o_found |= VDPA_OPT_VDEV_FEATURES;
 >                 } else {
 >                         fprintf(stderr, "Unknown option \"%s\"\n", 
*argv);
 > --
 > 2.17.1
 >

Re: [PATCH] vdpa: consume device_features parameter

[Nelson, Shannon]

On 9/7/2023 1:41 PM, Si-Wei Liu wrote:
> 
> Hi David,
> 
> Why this patch doesn't get picked in the last 4 months? Maybe the
> subject is not clear, but this is an iproute2 patch. Would it be
> possible to merge at your earliest convenience?
> 
> PS, adding my R-b to the patch.

Maybe I aimed this at the wrong person?  I see that Stephen just 
announced the latest iproute2
https://lore.kernel.org/netdev/20230906093918.394a1b1d@hermes.local/

I probably also should have made sure that "iproute2" was in the subject 
prefix.

Hi Stephen, perhaps you can help with this?

Thanks,
sln


> 
> Thanks,
> -Siwei
> 
> 
> On Sat, May 13, 2023 at 12:42 AM Shannon Nelson <shannon.nelson@amd.com>
> wrote:
>  >
>  > From: Allen Hubbe <allen.hubbe@amd.com>
>  >
>  > Consume the parameter to device_features when parsing command line
>  > options.  Otherwise the parameter may be used again as an option name.
>  >
>  >  # vdpa dev add ... device_features 0xdeadbeef mac 00:11:22:33:44:55
>  >  Unknown option "0xdeadbeef"
>  >
>  > Fixes: a4442ce58ebb ("vdpa: allow provisioning device features")
>  > Signed-off-by: Allen Hubbe <allen.hubbe@amd.com>
>  > Reviewed-by: Shannon Nelson <shannon.nelson@amd.com>
> 
> Reviewed-by: Si-Wei Liu <si-wei.liu@oracle.com>
> 
>  > ---
>  >  vdpa/vdpa.c | 2 ++
>  >  1 file changed, 2 insertions(+)
>  >
>  > diff --git a/vdpa/vdpa.c b/vdpa/vdpa.c
>  > index 27647d73d498..8a2fca8647b6 100644
>  > --- a/vdpa/vdpa.c
>  > +++ b/vdpa/vdpa.c
>  > @@ -353,6 +353,8 @@ static int vdpa_argv_parse(struct vdpa *vdpa, int
> argc, char **argv,
>  > &opts->device_features);
>  >                         if (err)
>  >                                 return err;
>  > +
>  > +                       NEXT_ARG_FWD();
>  >                         o_found |= VDPA_OPT_VDEV_FEATURES;
>  >                 } else {
>  >                         fprintf(stderr, "Unknown option \"%s\"\n",
> *argv);
>  > --
>  > 2.17.1
>  >
> 

Re: [PATCH] vdpa: consume device_features parameter

[David Ahern]

On 9/7/23 2:41 PM, Si-Wei Liu wrote:
> Hi David,
> 
> Why this patch doesn't get picked in the last 4 months? Maybe the
> subject is not clear, but this is an iproute2 patch. Would it be
> possible to merge at your earliest convenience?
> 
> PS, adding my R-b to the patch.
> 

It got marked "Not applicable":
https://patchwork.kernel.org/project/netdevbpf/patch/29db10bca7e5ef6b1137282292660fc337a4323a.1683907102.git.allen.hubbe@amd.com/

Resend the patch with any reviewed by tags and be sure to cc me.

Re: [PATCH] vdpa: consume device_features parameter

[Si-Wei Liu]

On 9/7/2023 5:07 PM, David Ahern wrote:
> On 9/7/23 2:41 PM, Si-Wei Liu wrote:
>> Hi David,
>>
>> Why this patch doesn't get picked in the last 4 months? Maybe the
>> subject is not clear, but this is an iproute2 patch. Would it be
>> possible to merge at your earliest convenience?
>>
>> PS, adding my R-b to the patch.
>>
> It got marked "Not applicable":
> https://patchwork.kernel.org/project/netdevbpf/patch/29db10bca7e5ef6b1137282292660fc337a4323a.1683907102.git.allen.hubbe@amd.com/
>
> Resend the patch with any reviewed by tags and be sure to cc me.
>
Just out of my own curiosity, the patch is not applicable simply because 
the iproute2 was missing from the subject, or the code base somehow got 
changed that isn't aligned with the patch any more?

Thanks,
-Siwei

Re: [PATCH] vdpa: consume device_features parameter

[David Ahern]

On 9/8/23 12:37 PM, Si-Wei Liu wrote:
> Just out of my own curiosity, the patch is not applicable simply because
> the iproute2 was missing from the subject, or the code base somehow got

most likely missing the iproute2 label in the Subject line

> changed that isn't aligned with the patch any more?
> 
> Thanks,
> -Siwei

Re: [PATCH] vdpa: consume device_features parameter

[Si-Wei Liu]

Thanks David, for clarifications. Now I see the patch just got posted by 
Shannon (thanks!) with the correct iproute2 label in the subject line. 
We may expect to see this land on iproute2 repo soon?

Thanks!
-Siwei

On 9/9/2023 1:36 PM, David Ahern wrote:
> On 9/8/23 12:37 PM, Si-Wei Liu wrote:
>> Just out of my own curiosity, the patch is not applicable simply because
>> the iproute2 was missing from the subject, or the code base somehow got
> most likely missing the iproute2 label in the Subject line
>
>> changed that isn't aligned with the patch any more?
>>
>> Thanks,
>> -Siwei