From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Durrant Subject: RE: [PATCH] xen-netback: remove unecessary condition check before debugfs_remove_recursive Date: Tue, 11 Sep 2018 08:00:02 +0000 Message-ID: <06106022e5344ccca2127e5afd6928d9@AMSPEX02CL03.citrite.net> References: <1536414822-32911-1-git-send-email-zhongjiang@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Cc: "xen-devel@lists.xenproject.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" To: 'zhong jiang' , "davem@davemloft.net" , Wei Liu Return-path: In-Reply-To: <1536414822-32911-1-git-send-email-zhongjiang@huawei.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org > -----Original Message----- > From: zhong jiang [mailto:zhongjiang@huawei.com] > Sent: 08 September 2018 14:54 > To: davem@davemloft.net; Paul Durrant ; Wei Liu > > Cc: xen-devel@lists.xenproject.org; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org > Subject: [PATCH] xen-netback: remove unecessary condition check before > debugfs_remove_recursive > > debugfs_remove_recursive has taken IS_ERR_OR_NULL into account. So just > remove the condition check before debugfs_remove_recursive. > > Signed-off-by: zhong jiang Reviewed-by: Paul Durrant > --- > drivers/net/xen-netback/netback.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen- > netback/netback.c > index 3621e05..80aae3a 100644 > --- a/drivers/net/xen-netback/netback.c > +++ b/drivers/net/xen-netback/netback.c > @@ -1660,8 +1660,7 @@ static int __init netback_init(void) > static void __exit netback_fini(void) > { > #ifdef CONFIG_DEBUG_FS > - if (!IS_ERR_OR_NULL(xen_netback_dbg_root)) > - debugfs_remove_recursive(xen_netback_dbg_root); > + debugfs_remove_recursive(xen_netback_dbg_root); > #endif /* CONFIG_DEBUG_FS */ > xenvif_xenbus_fini(); > } > -- > 1.7.12.4