From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FCE8C169C4 for ; Fri, 1 Feb 2019 01:19:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1574C2085B for ; Fri, 1 Feb 2019 01:19:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ba5RQed0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726114AbfBABTh (ORCPT ); Thu, 31 Jan 2019 20:19:37 -0500 Received: from mail-yw1-f68.google.com ([209.85.161.68]:33177 "EHLO mail-yw1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725870AbfBABTh (ORCPT ); Thu, 31 Jan 2019 20:19:37 -0500 Received: by mail-yw1-f68.google.com with SMTP id p65so2125116ywe.0 for ; Thu, 31 Jan 2019 17:19:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MHIC+dY1Vn3NREgugV0sDHZI+WwARDlOnl6vGKV98ho=; b=Ba5RQed021ZmBFx9vJD3u43tSMl0nn1X6C+0XLte6FNLL08TKG/8a7wV2glS2dW8OD +W2A8g8dDkI9jU6Vcbqrq/hBt4CM+LKph1ccWbsIRcAgieYOtAtSDoHjlabCnELPb2p7 ghVtXCBlnlMlVFPgpMU5PnysBB9vwi/ILMA6NgvFbePiLGlAqleYQ3NU0mDDIcDQRi/o yU0A/Ngnko5BCcmDh/aE2XsPc0GYUUBS/i7YzxPqPLhf/oLdor1/vlQKGymhlGpbzZqY APQIngH3AWV2rK+2A0GSsIlV6D7vJX5UywZ7P2UcmsQ2c9CiS5VdbAB22b1a7WG5lTmc aaIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=MHIC+dY1Vn3NREgugV0sDHZI+WwARDlOnl6vGKV98ho=; b=ksmFuDT1BbqyE4Ts1mRZ2wKezhknbsbdOXA83pEp/XFnBfHP1QpDMcS3bSIbvEVQ/u TWXz+QAXsSabn500/LTvkQR68MVTFosOrqB3SsJ5bnGLUppY/KT+3wUZuDPJv606lnEJ b2f/HblqYZEy2bxp7ipnS9OS8Py3ZCGPPABBIinOxmEtkh7UVYPn8TytB1U5KfmxdivW Q58hQeJXgOAty9BpBqFyh0OqIW2jzS8Gc/Z7JRzPGne4dEFLLsxfFIh0CtUarJ86++Ah NvJ7rYUH4jqcV8LpZ9sRp8EgOL7NEGRSVNvx8EsjXbL7vghPzyszT7kn9gssUd06yvMk Tp2Q== X-Gm-Message-State: AJcUuke7iPgWxy/EuaPAH5yUas8LJCJsvtLRdZtE9L9LRS5UnaAtZZTE v8jxDcCZ13IQsk26xDZcgHM= X-Google-Smtp-Source: ALg8bN5BdFnMXzrHXpYIx7PQ9CI8tGvcJM9kHTrGbSHv3n6xePZFvsRsercLo1cQCBUlIPIGgG47/Q== X-Received: by 2002:a0d:e446:: with SMTP id n67mr36354881ywe.478.1548983975401; Thu, 31 Jan 2019 17:19:35 -0800 (PST) Received: from [10.67.48.225] ([192.19.223.250]) by smtp.googlemail.com with ESMTPSA id v9sm3759385ywh.2.2019.01.31.17.19.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 31 Jan 2019 17:19:33 -0800 (PST) Subject: Re: [PATCH net-next v2 01/12] net: bridge: multicast: Propagate br_mc_disabled_update() return To: Ido Schimmel Cc: "netdev@vger.kernel.org" , "andrew@lunn.ch" , "vivien.didelot@gmail.com" , "davem@davemloft.net" , Jiri Pirko , "ilias.apalodimas@linaro.org" , "ivan.khoronzhuk@linaro.org" , "roopa@cumulusnetworks.com" , "nikolay@cumulusnetworks.com" , Petr Machata References: <20190130005548.2212-1-f.fainelli@gmail.com> <20190130005548.2212-2-f.fainelli@gmail.com> <20190130073656.GA22227@splinter> <63b446c5-8104-d9f9-3924-aaa481ee3b8c@gmail.com> <20190131075013.GA27839@splinter> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: <061dca81-a5ed-1498-060a-1a7a0e0a1116@gmail.com> Date: Thu, 31 Jan 2019 17:19:25 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190131075013.GA27839@splinter> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/30/19 11:50 PM, Ido Schimmel wrote: > On Wed, Jan 30, 2019 at 05:00:57PM -0800, Florian Fainelli wrote: >> On 1/29/19 11:36 PM, Ido Schimmel wrote: >>> On Tue, Jan 29, 2019 at 04:55:37PM -0800, Florian Fainelli wrote: >>>> -static void br_mc_disabled_update(struct net_device *dev, bool value) >>>> +static int br_mc_disabled_update(struct net_device *dev, bool value) >>>> { >>>> struct switchdev_attr attr = { >>>> .orig_dev = dev, >>>> .id = SWITCHDEV_ATTR_ID_BRIDGE_MC_DISABLED, >>>> - .flags = SWITCHDEV_F_DEFER, >>>> + .flags = SWITCHDEV_F_DEFER | SWITCHDEV_F_SKIP_EOPNOTSUPP, >>> >>> Actually, since the operation is deferred I don't think the return value >>> from the driver is ever checked. Can you test it? >> >> You are right, you get a WARN() from switchdev_attr_port_set_now(), but >> this does not propagate back to the caller, so you can still create a >> bridge device and enslave a device successfully despite getting warnings >> on the console. >> >>> >>> I think it would be good to convert the attributes to use the switchdev >>> notifier like commit d17d9f5e5143 ("switchdev: Replace port obj add/del >>> SDO with a notification") did for objects. Then you can have your >>> listener veto the operation in the same context it is happening. >> >> Alright, working on it. Would you do that just for the attr_set, or for >> attr_get as well (to be symmetrical)? > > Yes, then we can get rid of switchdev_ops completely. > OK, so here is what I have so far: https://github.com/ffainelli/linux/pull/new/switchdev-attr although I am seeing some invalid context operations with DSA that I am debugging. Does this look like the right way to go from your perspective? -- Florian