From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Laight Subject: RE: [PATCH net] sctp: fix a success return may hide an error Date: Tue, 16 Aug 2016 09:16:52 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6DB00DFD69@AcuExch.aculab.com> References: <31f3b581258d0458edcf30f65ef9513bdc41acc1.1470919978.git.lucien.xin@gmail.com> <20160812.211113.1099230839994600349.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: network dev , "linux-sctp@vger.kernel.org" , Marcelo Ricardo Leitner , Vladislav Yasevich , "daniel@iogearbox.net" To: 'Xin Long' , David Miller Return-path: Received: from smtp-out6.electric.net ([192.162.217.190]:53218 "EHLO smtp-out6.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752187AbcHPJTS (ORCPT ); Tue, 16 Aug 2016 05:19:18 -0400 In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: RnJvbTogWGluIExvbmcNCj4gU2VudDogMTMgQXVndXN0IDIwMTYgMDg6NDgNCj4gPg0KPiA+IFRo aXMgc3R5bGUgb2YgZXJyb3IgaGFuZGxpbmcgaXMgZGFuZ2Vyb3VzLiAgVGhlIGZpcnN0IGVycm9y IGNhbiBiZQ0KPiA+IGxvc3QuDQo+ID4NCj4gPiBGb3IgZXhhbXBsZSwgaWYgc2N0cF9vdXRxX2Zs dXNoX3J0eCgpIGVhcmxpZXIgaW4gdGhpcyBmdW5jdGlvbiByZXR1cm5zDQo+ID4gYW4gZXJyb3Is IGl0IHdpbGwgYmUgbG9zdCBpZiBhbnkgaW52b2NhdGlvbiBvZiB0aGUgZnVuY3Rpb24NCj4gPiBz Y3RwX3BhY2tldF90cmFuc21pdCgpIGF0IHRoZSBlbmQgZnVuY3Rpb24gc2lnbmFscyBhbiBlcnJv ci4NCj4gPg0KPiA+IEkgdGhpbmsgeW91IHNob3VsZCBhbHdheXMgcHJlc2VydmUgdGhlIGZpcnN0 IGVycm9yIHRoYXQgaXMgcmVjb3JkZWQNCj4gPiBpbnRvICdlcnJvcicuDQo+ID4NCj4gPiBJIGFs c28gd29uZGVyIGFib3V0IHdoeSBzY3RwX291dHFfZmx1c2hfcnR4KCkgZXJyb3JzIGFyZSBjb21w bGV0ZWx5DQo+ID4gaWdub3JlZCBhbmQgZG9uJ3QgaW5mbHVlbmNlIHRoZSBjb250cm9sIGZsb3cg aGVyZSBpbiBhbnkgd2F5Lg0KPiANCj4gWWVzLCB0aGUgZmlyc3QgZXJyb3IgY2FuIGJlIGxvc3Qu DQo+IEhlcmUgd2UganVzdCBrZWVwIHRoZSBsYXN0IGVycm9yLiBXZSBkb24ndCByZWFsbHkgaGF2 ZSB0byByZXR1cm4gdGhlDQo+IGZpcnN0IGVycm9yIG9yIHJldHVybiBpdCBvbiB0aGUgZmlyc3Qg ZmFpbHVyZS4NCj4gDQo+IFsxXQ0KPiBCb3RoIHNjdHBfb3V0cV9mbHVzaF9ydHggYW5kIHNjdHBf cGFja2V0X3RyYW5zbWl0IGNhbiBPTkxZDQo+IHJldHVybiBvbmUgZXJyb3IgKC1FTk9NRU0pLCBh cyBzY3RwX291dHFfZmx1c2hfcnR4IGFsc28gY2FsbHMNCj4gc2N0cF9wYWNrZXRfdHJhbnNtaXQu DQoNCldoYXQgaXMgdGhlIGVmZmVjdCBvZiB0aGUgZXJyb3I/DQpJZiBpdCBpcyAnanVzdCcgZXF1 aXZhbGVudCB0byBhIGxvc3QgZXRoZXJuZXQgcGFja2V0IChhbmQgdGhlIHNrYiAoZXRjKQ0KaXMg ZnJlZWQpIHRoZW4gdGhlIHByb3RvY29sIHdpbGwgcmVjb3Zlci4NCklmIGl0IGlzIGFueXRoaW5n IGVsc2UgdGhlbiB0aGUgZXJyb3IgcGF0aCBpcyBwcm9iYWJseSB3cm9uZy4NCg0KQWxzbyBhZnRl ciBvbmUgZXJyb3IgaXMgaXQgYWN0dWFsbHkgd29ydGggdHJ5aW5nIHRvIHNlbmQgYW55dGhpbmcg ZWxzZQ0KYXQgYWxsPyBJU1RNIHRoYXQgdGhlIGNvZGUgc2hvdWxkIGVpdGhlcjoNCjEpIHdhaXQg Zm9yIHJlc291cmNlcyBhbmQgcmV0cnkuDQoyKSBkaXNjYXJkIHRoZSBlbnRpcmUgcXVldWUgKGZy ZWVpbmcgcmVzb3VyY2UpIGFuZCBob3BlIHRoZSBwcm90b2NvbA0KICAgdGltZXJzIHdpbGwgcmVj b3Zlci4NCg0KPiBbMl0NCj4gSXQncyB0aGUgb3JpZ2luYWwgY29kZXMgdGhhdCBpdCBkb2Vzbid0 IHJldHVybiBpbW1lZGlhdGVseSB3aGVuDQo+IHNjdHBfb3V0cV9mbHVzaF9ydHggcmV0dXJucyBl cnJvci4gSSBndWVzcyBpdCBqdXN0IGRvZXNuJ3Qgd2FudA0KPiB0byBzdG9wIGZsdXNoaW5nIG91 dCB0cmFuc3BvcnRfbGlzdCBvbmx5IGJlY2F1c2UgaXQgZmFpbCB0byBmbHVzaA0KPiBydHguDQo+ IGV2ZW4gc2N0cF9wYWNrZXRfdHJhbnNtaXRfY2h1bmsgaW4gc2N0cF9vdXRxX2ZsdXNoIGFsc28g anVzdA0KPiBwdXQgdGhlIGVycm9yIGludG8gc2stPnNrX2VyciwgaW5zdHJlYWQgb2YgcmV0dXJu aW5nIGltbWVkaWF0ZWx5Lg0KPiANCj4gU28gd2UgY2Fubm90IHJldHVybiB0aGUgZXJyIGF0IHRo ZSBmaXJzdCBmYWlsdXJlIGFzIFsyXSwgdGhlIGVycm9yDQo+IGhlcmUgaXMgYWx3YXlzIC1FTk9N RU0gYXMgWzFdLg0KPiBJIHRoaW5rIHRvIHJldHVybiB0aGUgbGFzdCBlcnJvciBoZXJlIGlzIG9r LCBhdCBsZWFzdCAgbm90IGRhbmdlcm91cywNCj4gY2FuIGFsc28gZml4IHRoZSBpc3N1ZSAiYSBz dWNjZXNzIHJldHVybiBtYXkgaGlkZSBhbiBlcnJvciIgd2l0aA0KPiBjbGVhciBjb2Rlcy4gOikN Cg0KV2hpY2ggY29kZSBsb29rcyBhdCBzay0+c2tfZXJyPw0KSXQgZG9lc24ndCBsb29rIHJpZ2h0 IHRvIGJlIHNldHRpbmcgYW4gZXJyb3IgY29kZSBvbiB0aGUgc29ja2V0IGR1ZQ0KYSB0cmFuc21p dCBwYWNrZXQgZGlzY2FyZC4NCg0KCURhdmlkDQoNCg==