From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Russell King \(Oracle\)'" <rmk+kernel@armlinux.org.uk>
Cc: "'David S. Miller'" <davem@davemloft.net>,
"'Eric Dumazet'" <edumazet@google.com>,
"'Jakub Kicinski'" <kuba@kernel.org>,
"'Paolo Abeni'" <pabeni@redhat.com>, <netdev@vger.kernel.org>
Subject: RE: [PATCH net-next] net: txgbe: use phylink_pcs_change() to report PCS link change events
Date: Sun, 28 Apr 2024 15:50:24 +0800 [thread overview]
Message-ID: <064b01da9940$baa36cc0$2fea4640$@trustnetic.com> (raw)
In-Reply-To: <E1s0OH2-009hgx-Qw@rmk-PC.armlinux.org.uk>
On Sat, April 27, 2024 12:18 AM, Russell King <rmk@armlinux.org.uk> wrote:
> Use phylink_pcs_change() when reporting changes in PCS link state to
> phylink as the interrupts are informing us about changes to the PCS
> state.
>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> ---
> drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c
> index 93295916b1d2..5f502265f0a6 100644
> --- a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c
> +++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c
> @@ -302,7 +302,7 @@ irqreturn_t txgbe_link_irq_handler(int irq, void *data)
> status = rd32(wx, TXGBE_CFG_PORT_ST);
> up = !!(status & TXGBE_CFG_PORT_ST_LINK_UP);
>
> - phylink_mac_change(wx->phylink, up);
> + phylink_pcs_change(&txgbe->xpcs->pcs, up);
>
> return IRQ_HANDLED;
> }
Does this only affect the log of phylink_dbg()?
If so,
Acked-by: Jiawen Wu <jiawenwu@trustnetic.com>
next prev parent reply other threads:[~2024-04-28 7:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 16:18 [PATCH net-next] net: txgbe: use phylink_pcs_change() to report PCS link change events Russell King (Oracle)
2024-04-28 7:50 ` Jiawen Wu [this message]
2024-04-28 8:02 ` Russell King (Oracle)
2024-04-30 2:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='064b01da9940$baa36cc0$2fea4640$@trustnetic.com' \
--to=jiawenwu@trustnetic.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).