From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH v2 net-next] inet: do not set backlog if listen fails Date: Sun, 7 Oct 2018 10:39:21 -0700 Message-ID: <0652963b-90ac-06a7-3a35-50a307465cf9@gmail.com> References: <1538919405-3093-1-git-send-email-laoar.shao@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Yafang Shao , edumazet@google.com, davem@davemloft.net Return-path: In-Reply-To: <1538919405-3093-1-git-send-email-laoar.shao@gmail.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 10/07/2018 06:36 AM, Yafang Shao wrote: > We don't need to set the backlog if listen fails. > The sk_max_ack_backlog will be set in the caller inet_listen() and > dccp_listen_start() if inet_csk_listen_start() return without error. > So just remove this line to avoid this unnecessary operation. > > Regarding sk_ack_backlog, we have to set it before a TCP/DCCP socket is > ready to accept new flows to avoid race, because dccp and tcp have lockless > listeners > Really could you not add irrelevant stuff in the changelog ? This patch simply removes one redundant setting, you do not have to explain about dccp/tcp being lockless and that sk_ack_backlog is not touched by this patch. Also the title is misleading, since we will still set the backlog even if the listen fails. If you really want sk_max_ack_backlog being not changed if listen() fails, then I am afraid you will need to submit a different patch.