Netdev List
 help / color / mirror / Atom feed
From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Simon Horman'" <horms@kernel.org>
Cc: <netdev@vger.kernel.org>,
	"'Mengyuan Lou'" <mengyuanlou@net-swift.com>,
	"'Andrew Lunn'" <andrew+netdev@lunn.ch>,
	"'David S. Miller'" <davem@davemloft.net>,
	"'Eric Dumazet'" <edumazet@google.com>,
	"'Jakub Kicinski'" <kuba@kernel.org>,
	"'Paolo Abeni'" <pabeni@redhat.com>,
	"'Kees Cook'" <kees@kernel.org>,
	"'Larysa Zaremba'" <larysa.zaremba@intel.com>,
	"'Jacob Keller'" <jacob.e.keller@intel.com>,
	<netdev@vger.kernel.org>,
	"'Mengyuan Lou'" <mengyuanlou@net-swift.com>,
	"'Andrew Lunn'" <andrew+netdev@lunn.ch>,
	"'David S. Miller'" <davem@davemloft.net>,
	"'Eric Dumazet'" <edumazet@google.com>,
	"'Jakub Kicinski'" <kuba@kernel.org>,
	"'Paolo Abeni'" <pabeni@redhat.com>,
	"'Kees Cook'" <kees@kernel.org>,
	"'Larysa Zaremba'" <larysa.zaremba@intel.com>,
	"'Jacob Keller'" <jacob.e.keller@intel.com>
Subject: RE: [PATCH net-next v2 0/3] wangxun: improve service task synchronization
Date: Thu, 28 May 2026 10:28:28 +0800	[thread overview]
Message-ID: <065b01dcee49$ab3f2de0$01bd89a0$@trustnetic.com> (raw)
In-Reply-To: <20260527143114.GM2256768@horms.kernel.org>

On Wed, May 27, 2026 10:31 PM, Simon Horman wrote:
> On Mon, May 25, 2026 at 06:05:40PM +0800, Jiawen Wu wrote:
> > This series improves synchronization between asynchronous service work,
> > device teardown, and module event handling in the Wangxun drivers.
> >
> > ---
> > v2:
> > - Check WX_STATE_DOWN before setting WX_STATE_SERVICE_SCHED.
> >
> > v1: https://lore.kernel.org/all/20260519080048.7448-1-jiawenwu@trustnetic.com
> 
> Hi Jiawen,
> 
> There are AI-generated reviews of this patch-set available at
> https://netdev-ai.bots.linux.dev/ and https://sashiko.dev/
> 
> I would appreciate it if you could look over them and address any
> issues that are either introduced by this patch-set, or directly
> impact it.
> 
> I would not suggest expanding this patchset to address any other
> pre-existing issues, but rather address them separately as appropriate.

Hi,

Looked over AI-generated reviews, there are some issues need to be clarified.

Sashiko-nipa exposes an existing issue in the wxvf resume flow.  The VF PM
resume path currently calls wx_init_interrupt_scheme() followed by
netif_device_attach(), but does not reopen the device when the interface
was running before suspend. I plan to address this separately by fixing the
wxvf resume flow.

Sashiko-gemini exposes some issues but none of them were introduced by
this patch set. And one issue I've clarified in the previous version.



      reply	other threads:[~2026-05-28  2:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-25 10:05 [PATCH net-next v2 0/3] wangxun: improve service task synchronization Jiawen Wu
2026-05-25 10:05 ` [PATCH net-next v2 1/3] net: wangxun: introduce WX_STATE_DOWN to serialize device shutdown state Jiawen Wu
2026-05-25 10:05 ` [PATCH net-next v2 2/3] net: wangxun: avoid statistics updates during device teardown Jiawen Wu
2026-05-25 10:05 ` [PATCH net-next v2 3/3] net: txgbe: rework service event handling Jiawen Wu
2026-05-27 14:31 ` [PATCH net-next v2 0/3] wangxun: improve service task synchronization Simon Horman
2026-05-28  2:28   ` Jiawen Wu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='065b01dcee49$ab3f2de0$01bd89a0$@trustnetic.com' \
    --to=jiawenwu@trustnetic.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jacob.e.keller@intel.com \
    --cc=kees@kernel.org \
    --cc=kuba@kernel.org \
    --cc=larysa.zaremba@intel.com \
    --cc=mengyuanlou@net-swift.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox