From: Andreas Roeseler <andreas.a.roeseler@gmail.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Network Development <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net-next V5 6/6] icmp: add response to RFC 8335 PROBE messages
Date: Mon, 29 Mar 2021 13:33:39 -0500 [thread overview]
Message-ID: <065c20b62c479ecd2a9d3bb7bf36de1ac8390a55.camel@gmail.com> (raw)
In-Reply-To: <CA+FuTSeBRCDcu7uKp9=7UZWR3zmSrk41ArqrseW9jHYgK+WPpg@mail.gmail.com>
On Sun, 2021-03-28 at 13:00 -0400, Willem de Bruijn wrote:
> On Wed, Mar 24, 2021 at 2:20 PM Andreas Roeseler
> <andreas.a.roeseler@gmail.com> wrote:
> >
>
> > + if (!ext_hdr || !iio)
> > + goto send_mal_query;
> > + if (ntohs(iio->extobj_hdr.length) <= sizeof(iio-
> > >extobj_hdr))
> > + goto send_mal_query;
> > + ident_len = ntohs(iio->extobj_hdr.length) - sizeof(iio-
> > >extobj_hdr);
>
> As asked in v3: this can have negative overflow?
The line above checks that iio->extobj_hdr.length is greater than the
size of iio->extobj_hdr.
next prev parent reply other threads:[~2021-03-29 18:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 18:17 [PATCH net-next V5 0/6] add support for RFC 8335 PROBE Andreas Roeseler
2021-03-24 18:17 ` [PATCH net-next V5 1/6] icmp: " Andreas Roeseler
2021-03-24 18:17 ` [PATCH net-next V5 2/6] ICMPV6: " Andreas Roeseler
2021-03-24 18:18 ` [PATCH net-next V5 3/6] net: add sysctl for enabling RFC 8335 PROBE messages Andreas Roeseler
2021-03-24 18:18 ` [PATCH net-next V5 4/6] net: add support for sending " Andreas Roeseler
2021-03-24 18:18 ` [PATCH net-next V5 5/6] ipv6: add ipv6_dev_find to stubs Andreas Roeseler
2021-03-24 18:18 ` [PATCH net-next V5 6/6] icmp: add response to RFC 8335 PROBE messages Andreas Roeseler
2021-03-24 19:47 ` Eric Dumazet
2021-03-24 20:24 ` Andreas Roeseler
2021-03-28 17:00 ` Willem de Bruijn
2021-03-29 18:33 ` Andreas Roeseler [this message]
2021-03-29 18:42 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=065c20b62c479ecd2a9d3bb7bf36de1ac8390a55.camel@gmail.com \
--to=andreas.a.roeseler@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).