From: Florian Fainelli <f.fainelli@gmail.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Andrew Lunn <andrew@lunn.ch>
Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH RFC 3/6] net: phy: Threaded interrupts allow some simplification
Date: Wed, 28 Sep 2016 10:14:21 -0700 [thread overview]
Message-ID: <06bdfcb4-8bb6-28e6-00e5-2518f79f729d@gmail.com> (raw)
In-Reply-To: <891f6b60-47a0-ba03-d6d3-8284993d1896@cogentembedded.com>
On 09/28/2016 06:38 AM, Sergei Shtylyov wrote:
> On 09/28/2016 03:28 PM, Andrew Lunn wrote:
>
>>>>> The PHY interrupts are now handled in a threaded interrupt handler,
>>>>> which can sleep. The work queue is no longer needed, phy_change() can
>>>>> be called directly. Additionally, none of the callers of
>>>>> phy_mac_interrupt() did so in interrupt context, so fully remove the
>>>>
>>>> I did intend to call it from interrupt context (from the ravb
>>>> driver).
>>>>
>>>>> work queue, and document that phy_mac_interrupt() should not be called
>>>>> in interrupt context.
>>>>
>>>> It was intentionally made callable from the interrupt context, I'd
>>>> prefer
>>>> if you wouldn't change that.
>>>
>>> OTOH, it's still not very handy to call because of the 'new_link'
>>> parameter which I'm not sure I can provide...
>>
>> Hi Sergei
>>
>> If there is a need for it, i will leave the work queue and keep this
>> code unchanged.
>
> Let's hear what Florian says...
The intent is really to have phy_mac_interrupt() callable from hard IRQ
context, not that this matters really too much because link events
already occur in the slow path, but it's nice to have that property
retained IMHO.
--
Florian
next prev parent reply other threads:[~2016-09-28 17:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1475051544-18561-1-git-send-email-andrew@lunn.ch>
2016-09-28 8:32 ` [PATCH RFC 1/6] net: dsa: mv88e6xxx: Implement interrupt support Andrew Lunn
2016-09-28 10:22 ` Andrew Lunn
2016-09-28 8:32 ` [PATCH RFC 2/6] net: phy: Use threaded IRQ, to allow IRQ from sleeping devices Andrew Lunn
2016-09-28 11:38 ` Sergei Shtylyov
2016-09-28 12:24 ` Andrew Lunn
2016-09-28 21:16 ` Andrew Lunn
2016-09-28 8:32 ` [PATCH RFC 3/6] net: phy: Threaded interrupts allow some simplification Andrew Lunn
2016-09-28 11:46 ` Sergei Shtylyov
2016-09-28 12:13 ` Sergei Shtylyov
2016-09-28 12:28 ` Andrew Lunn
2016-09-28 13:38 ` Sergei Shtylyov
2016-09-28 17:14 ` Florian Fainelli [this message]
2016-10-18 10:37 ` Sergei Shtylyov
2016-10-18 10:46 ` Andrew Lunn
2016-09-28 8:32 ` [PATCH RFC 4/6] net: phy: Use phy name when requesting the interrupt Andrew Lunn
2016-09-28 17:18 ` Florian Fainelli
2016-09-28 8:32 ` [PATCH RFC 5/6] net: phy: Trigger state machine on state change and not polling Andrew Lunn
2016-09-28 21:31 ` Florian Fainelli
2016-09-29 7:08 ` Andrew Lunn
2016-09-28 8:32 ` [PATCH RFC 6/6] arm: vf610: zii devel b: Add support for switch interrupts Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06bdfcb4-8bb6-28e6-00e5-2518f79f729d@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).