Netdev List
 help / color / mirror / Atom feed
From: Mieczyslaw Nalewaj <namiltd@yahoo.com>
To: netdev-bot+sashiko@kernel.org
Cc: linusw@kernel.org, andrew@lunn.ch, olteanv@gmail.com,
	kuba@kernel.org, davem@davemloft.net, edumazet@google.com,
	pabeni@redhat.com, linux@armlinux.org.uk, luizluca@gmail.com,
	maxime.chevallier@bootlin.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, alvin.sipraga@analog.com,
	gusfmora@gmail.com, kuncy7@gmail.com, fabianotassotti@gmail.com,
	gabonpivovich@gmail.com, contact@c127.dev
Subject: Re: [PATCH net-next v10 08/12] net: dsa: realtek: rtl8365mb: use raw VID for PVID on family D
Date: Tue, 17 Nov 2026 07:28:45 +0100	[thread overview]
Message-ID: <06c0ca53-dc0c-497d-bd2b-06d2f678c0de@yahoo.com> (raw)
In-Reply-To: <179485535671.3136.12858129949728945036@kernel.org>

Hi,

Thanks for the review. Replying to the two PVID points.

> Is there something that prevents the family C MCIDX fields and VLANMC entries from being loaded from EEPROM as well?

Nothing prevents it in principle, but I would like to keep it out of this series. The series is meant to leave family C behaviour untouched, and the family C regression runs (RTL8367S on Archer AX55 v1) were done with the existing setup path. Writing the PVID registers of every family C port at setup would be a behaviour change on chips this series does not otherwise touch, so it is better done as a separate patch with its own justification and testing.

The family D case is different in kind: there the register holds a raw VID with no VLANMC indirection, so a non-zero hardware or EEPROM default is directly used as the PVID by rtl8365mb_vlan_port_get_pvid() and rtl8365mb_port_vlan_filtering(). I could not rule that out for a chip whose reset state I cannot verify against the vendor API, hence the explicit clear.

I agree the kernel-doc of rtl8365mb_c_vlan_port_reset_pvid() should not claim more than is known. I will reword it in the next revision to say that family C relies on the reset value of the register and does not defend against an EEPROM-preloaded MC index. If you or Luiz would rather have family C cleared as well, I can send that as a separate follow-up.

> Luiz raised these points on v7 ... I don't see these points addressed or answered in this version.

This is addressed in v11. The rtl8365mb_is_d() branches and the _direct helpers are gone, and PVID get/set/clear/reset now go through struct rtl8365mb_family_info, with separate family C (8/13) and family D (9/13) implementations. VLANMC index 0 is described as a driver convention, not as a hardware neutral PVID.

Best regards,
Mieczyslaw Nalewaj

  reply	other threads:[~2026-11-17  6:28 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <d9da17af-f49e-4878-a8dd-59a8919e6930.ref@yahoo.com>
2026-11-12 17:31 ` [PATCH net-next v10 00/12] net: dsa: realtek: rtl8365mb: add support for RTL8367S-VB Mieczyslaw Nalewaj
2026-11-12 17:32   ` [PATCH net-next v10 01/12] dt-bindings: net: dsa: realtek: add RTL8367S-VB Mieczyslaw Nalewaj
2026-11-12 17:33   ` [PATCH net-next v10 02/12] net: dsa: realtek: rtl8365mb: add chip family infrastructure Mieczyslaw Nalewaj
2026-11-12 17:33   ` [PATCH net-next v10 03/12] net: dsa: realtek: rtl8365mb: refactor forcemode handling Mieczyslaw Nalewaj
2026-11-12 20:23     ` Linus Walleij
2026-11-12 17:34   ` [PATCH net-next v10 04/12] net: dsa: realtek: rtl8365mb: set speed for family D Mieczyslaw Nalewaj
2026-11-12 17:35   ` [PATCH net-next v10 05/12] net: dsa: realtek: rtl8365mb: set RGMII mode " Mieczyslaw Nalewaj
2026-11-12 17:36   ` [PATCH net-next v10 06/12] net: dsa: realtek: rtl8365mb: refactor VLAN 4k handling Mieczyslaw Nalewaj
2026-11-12 20:24     ` Linus Walleij
2026-11-12 17:37   ` [PATCH net-next v10 07/12] net: dsa: realtek: rtl8365mb: set and get vlan 4k for family D Mieczyslaw Nalewaj
2026-11-12 20:25     ` Linus Walleij
2026-11-16 18:55     ` netdev-bot+sashiko
2026-11-12 17:38   ` [PATCH net-next v10 08/12] net: dsa: realtek: rtl8365mb: use raw VID for PVID on " Mieczyslaw Nalewaj
2026-11-16 18:55     ` netdev-bot+sashiko
2026-11-17  6:28       ` Mieczyslaw Nalewaj [this message]
2026-11-12 17:39   ` [PATCH net-next v10 09/12] net: dsa: realtek: rtl8365mb: add family D SDS13 PCS support Mieczyslaw Nalewaj
2026-11-16 18:55     ` netdev-bot+sashiko
2026-11-12 17:40   ` [PATCH net-next v10 10/12] net: dsa: realtek: rtl8365mb: refactor L2 MAC handling Mieczyslaw Nalewaj
2026-11-12 20:26     ` Linus Walleij
2026-11-12 17:41   ` [PATCH net-next v10 11/12] net: dsa: realtek: rtl8365mb: make L2/LUT access work on family D Mieczyslaw Nalewaj
2026-11-16 18:55     ` netdev-bot+sashiko
2026-11-17  6:33       ` Mieczyslaw Nalewaj
2026-11-12 17:42   ` [PATCH net-next v10 12/12] net: dsa: realtek: rtl8365mb: add support for RTL8367S-VB Mieczyslaw Nalewaj
2026-11-16 18:56     ` netdev-bot+sashiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06c0ca53-dc0c-497d-bd2b-06d2f678c0de@yahoo.com \
    --to=namiltd@yahoo.com \
    --cc=alvin.sipraga@analog.com \
    --cc=andrew@lunn.ch \
    --cc=contact@c127.dev \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fabianotassotti@gmail.com \
    --cc=gabonpivovich@gmail.com \
    --cc=gusfmora@gmail.com \
    --cc=kuba@kernel.org \
    --cc=kuncy7@gmail.com \
    --cc=linusw@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=luizluca@gmail.com \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev-bot+sashiko@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox