Re: [PATCH net-next 3/3] selftests: tc-testing: add gact probability dump tests

[Paolo Abeni <pabeni@redhat.com>]

On 11/6/26 07:41, Linkui Xiao wrote:
> gact probability attributes are emitted by tcf_gact_dump() only when
> tcfg_ptype is set, and budgeted for by tcf_gact_get_fill_size().  The
> only gact cases that look at a probability today are 8e47 and ca89, and
> both check it through `tc actions list`, which is served by the netlink
> dump machinery and never consumes the get_fill_size() budget.  The one
> case that uses `tc actions get`, 525f, runs against an action with no
> probability, so the RTM_GETACTION reply path -- tcf_get_notify(), which
> does size its skb from get_fill_size() -- is never exercised with a
> probability, and the netrand random type is not exercised anywhere.
> 
> Add three cases: adding an action with a netrand probability and getting
> it back; replacing a probability-less action with a deterministic one
> and getting it back, covering the tcfg_ptype 0 -> non-zero transition
> that the unconditional TCA_GACT_PROB budget in patch 1 has to cover; and
> getting a probability-less action, whose dump must report no probability.
> 
> These are coverage for the dump and sizing paths that nothing tested
> before, not reproducers: RTM_NEWACTION, RTM_DELACTION and RTM_GETACTION
> all take
> rtnl, so sizing and dumping always run in the same critical section
> and a replace cannot interleave between them from userspace.  They pass
> both before and after patches 1 and 2.
> 
> Verified by running the tdc gact suite (38 cases, including these
> three) against a kernel with CONFIG_GACT_PROB=y and this series
> applied; all passed.
> 
> Signed-off-by: Linkui Xiao <xiaolinkui@kylinos.cn>
I think the value carried by the added tests is too low and new tests
consume nipa resources. Let me apply the first 2 patches without this one

/P