From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-181.mta1.migadu.com (out-181.mta1.migadu.com [95.215.58.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A01138DE1 for ; Fri, 10 Jan 2025 00:28:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736468909; cv=none; b=fjjBLj/jHGvXDfHZQAOzLAfTjE18MrtCG1hUuukYtCVE6zC1A7Vi66byFGv4ScjmL61SHPSgOPnrZEGa8HRW7UNqToMjhKqlAA3FtdImsUXtBP5rWWa+wQ3eQYq8xf2+3e5mr3MXHSTIJokCEUZ+chlv9/nNhAMEDgQc0aOnWSI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736468909; c=relaxed/simple; bh=H7H+E1zQIOwIrg3Sj1sOWdKQeVZ5YLM60Lk74uL/Lso=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=M4cRSq3oQ1zPdyvP8G6R2cjYvgUMBnZPmMXziGBnU1nFi2RFghDm02qJb8n80d4skB0qdfwNVG5Xt2QKFlfqgwmPoNgmpPNRPjO1nD94WrHBdrUg8opXTZnQfM8KUoYkEgCfK9w4YOuPvtwNDTCKTdQ5JcZPzPVSlYxMkc/gUWY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=OB4kyZij; arc=none smtp.client-ip=95.215.58.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="OB4kyZij" Message-ID: <06c1d122-f145-4461-9597-13f5b45367b6@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1736468905; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SqkvwdFA/zLCFS4qjtqosqWbhjFndiwKtnK3xGz1uXs=; b=OB4kyZijSkPeQJHq8Fl+CEI6PsNnS1bCyJ+EE4KCe1ThlrMMLsvsyfZm9Cq8fCjmACxpq0 3nKHNP4QtC++EKZY2rOTRAbC0WD3AJRsVHLiYEoDlJOd45XyOdLeslox23FOCsWv5Mm2Mn ukNwReuHIf/aIEuEpggKjpkkHhqhvyw= Date: Thu, 9 Jan 2025 16:28:20 -0800 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH bpf-next v2 05/14] bpf: net_sched: Support implementation of Qdisc_ops in bpf To: Amery Hung Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, daniel@iogearbox.net, andrii@kernel.org, alexei.starovoitov@gmail.com, martin.lau@kernel.org, sinquersw@gmail.com, toke@redhat.com, jhs@mojatatu.com, jiri@resnulli.us, stfomichev@gmail.com, ekarani.silvestre@ccc.ufcg.edu.br, yangpeihao@sjtu.edu.cn, xiyou.wangcong@gmail.com, yepeilin.cs@gmail.com References: <20241220195619.2022866-1-amery.hung@gmail.com> <20241220195619.2022866-6-amery.hung@gmail.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Martin KaFai Lau In-Reply-To: <20241220195619.2022866-6-amery.hung@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 12/20/24 11:55 AM, Amery Hung wrote: > +static const struct bpf_func_proto * > +bpf_qdisc_get_func_proto(enum bpf_func_id func_id, > + const struct bpf_prog *prog) > +{ > + switch (func_id) { > + case BPF_FUNC_tail_call: Since it needs a respin, a comment will be useful here to explain why tail_call is excluded. > + return NULL; > + default: > + return bpf_base_func_proto(func_id, prog); > + } > +}