From: Jacob Keller <jacob.e.keller@intel.com>
To: Tariq Toukan <tariqt@nvidia.com>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>, Mark Bloch <mbloch@nvidia.com>,
<netdev@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Gal Pressman <gal@nvidia.com>,
Moshe Shemesh <moshe@nvidia.com>, Shay Drory <shayd@nvidia.com>
Subject: Re: [PATCH net 1/6] net/mlx5: Fix multiport device check over light SFs
Date: Thu, 12 Feb 2026 14:25:28 -0800 [thread overview]
Message-ID: <06db9958-e5b3-46db-a8f5-1c2aa8cfac4f@intel.com> (raw)
In-Reply-To: <20260212103217.1752943-2-tariqt@nvidia.com>
On 2/12/2026 2:32 AM, Tariq Toukan wrote:
> From: Shay Drory <shayd@nvidia.com>
>
> Driver is using num_vhca_ports capability to distinguish between
> multiport master device and multiport slave device. num_vhca_ports is a
> capability the driver sets according to the MAX num_vhca_ports
> capability reported by FW. On the other hand, light SFs doesn't set the
> above capbility.
>
> This leads to wrong results whenever light SFs is checking whether he is
> a multiport master or slave.
>
> Therefore, use the MAX capability to distinguish between master and
> slave devices.
>
So we were previously checking the number of VHCA ports, but since SFs
set this to 0, they would always be ported as mp_slave, even though they
should be mp_master.
Makes sense.
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
next prev parent reply other threads:[~2026-02-12 22:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-12 10:32 [PATCH net 0/6] mlx5 misc fixes 2026-02-12 Tariq Toukan
2026-02-12 10:32 ` [PATCH net 1/6] net/mlx5: Fix multiport device check over light SFs Tariq Toukan
2026-02-12 22:25 ` Jacob Keller [this message]
2026-02-12 10:32 ` [PATCH net 2/6] net/mlx5: Fix misidentification of write combining CQE during poll loop Tariq Toukan
2026-02-12 22:36 ` Jacob Keller
2026-02-15 12:13 ` Gal Pressman
2026-02-12 10:32 ` [PATCH net 3/6] net/mlx5e: Fix misidentification of ASO " Tariq Toukan
2026-02-12 22:38 ` Jacob Keller
2026-02-12 10:32 ` [PATCH net 4/6] net/mlx5e: MACsec, add ASO poll loop in macsec_aso_set_arm_event Tariq Toukan
2026-02-12 10:32 ` [PATCH net 5/6] net/mlx5e: Fix deadlocks between devlink and netdev instance locks Tariq Toukan
2026-02-12 22:41 ` Jacob Keller
2026-02-12 10:32 ` [PATCH net 6/6] net/mlx5e: Use unsigned for mlx5e_get_max_num_channels Tariq Toukan
2026-02-12 22:41 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06db9958-e5b3-46db-a8f5-1c2aa8cfac4f@intel.com \
--to=jacob.e.keller@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=shayd@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox